Skip to content

fix: harden npm publish verification - #2261

Merged
tamirdresher merged 1 commit into
github:devfrom
tamirdresher:squad/2230-harden-npm-publish-verification
Oct 20, 2026
Merged

tamirdresher merged 1 commit into
github:devfrom
tamirdresher:squad/2230-harden-npm-publish-verification

Conversation

@tamirdresher

Copy link
Copy Markdown
Collaborator

Summary

  • extend npm publication verification from 5 to 20 attempts at 15-second intervals
  • let existing packages with temporarily stale dist-tags reach the retrying verification step
  • add workflow regression coverage for the five-minute polling window

Validation

  • npx vitest run test/standalone-release-workflow.test.ts test/publish-policy.test.ts test/squad-cli-pin.test.ts test/promote-insider-tag.test.ts
  • node --test test/*.test.cjs
  • npm run build

Closes #2227
Closes #2230

Closes github#2227

Closes github#2230

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 58833b4b-f8e7-42b8-bf04-9121f362f68c
Copilot AI balanced review requested due to automatic review settings October 20, 2026 07:42
@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Architectural Review

Authoritative evidence: base-controlled pull_request_target reporter.

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

@github-actions

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2261

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 2
Files added 0
Files modified 2
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 2 files changed (≤5 → LOW)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

ci-workflows (1 file)
  • .github/workflows/squad-npm-publish.yml
tests (1 file)
  • test/standalone-release-workflow.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 7c7be82

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
❌ CI passing 10 check(s) still running

Files Changed (2 files, +21 −19)

File +/−
.github/workflows/squad-npm-publish.yml +8 −16
test/standalone-release-workflow.test.ts +13 −3

Total: +21 −19


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes tolerate propagation delays without weakening publication verification, and no blocking issues remain.

No open issues 🎉

What changed in this PR

Hardens SDK and CLI npm publication verification against registry propagation delays.

Changes:

  • Increases verification to 20 attempts with 15-second waits.
  • Allows existing versions with stale dist-tags to reach retrying verification.
  • Updates regression assertions for both package paths.
File Description
test/​standalone-release-workflow.test.ts Checks stale-tag handling and expanded retry settings.
.github/​workflows/​squad-npm-publish.yml Extends polling while preserving version and dist-tag validation.

Review effort: Balanced

@tamirdresher
tamirdresher merged commit d5076d9 into github:dev Oct 20, 2026
18 checks passed
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Oct 20, 2026
Include the npm publication verification hardening merged in github#2261.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 58833b4b-f8e7-42b8-bf04-9121f362f68c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.0.1 did not publish Version 1.0.1 of squad-cli not available on npm

2 participants