Repository navigation
fix: harden npm publish verification - #2261
tamirdresher merged 1 commit into
Conversation
Closes github#2227 Closes github#2230 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58833b4b-f8e7-42b8-bf04-9121f362f68c
🏗️ Architectural Review
Automated architectural review — informational only. |
🟡 Impact Analysis — PR #2261Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 10 check(s) still running |
Files Changed (2 files, +21 −19)
| File | +/− |
|---|---|
.github/workflows/squad-npm-publish.yml |
+8 −16 |
test/standalone-release-workflow.test.ts |
+13 −3 |
Total: +21 −19
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes tolerate propagation delays without weakening publication verification, and no blocking issues remain.
No open issues 🎉
What changed in this PR
Hardens SDK and CLI npm publication verification against registry propagation delays.
Changes:
- Increases verification to 20 attempts with 15-second waits.
- Allows existing versions with stale dist-tags to reach retrying verification.
- Updates regression assertions for both package paths.
| File | Description |
|---|---|
| test/standalone-release-workflow.test.ts | Checks stale-tag handling and expanded retry settings. |
| .github/workflows/squad-npm-publish.yml | Extends polling while preserving version and dist-tag validation. |
Review effort: Balanced
Include the npm publication verification hardening merged in github#2261. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 58833b4b-f8e7-42b8-bf04-9121f362f68c
Summary
Validation
npx vitest run test/standalone-release-workflow.test.ts test/publish-policy.test.ts test/squad-cli-pin.test.ts test/promote-insider-tag.test.tsnode --test test/*.test.cjsnpm run buildCloses #2227
Closes #2230