[tamirdresher]

Summary

• Require granular activation (impl-accepted and impl-phases-accepted) in prepareActivation to uniquely reference the selected implementation plan comment revision (planComment.id) using standard producer plan-link representations (#issuecomment- URLs and comment-id references).
• Verify Implementation SHA-256: when present so edited/stale plan revisions are rejected before reservation or issue creation.
• Select the latest matching implementation acceptance artifact (.at(-1)) consistent with scope and �alidation selection, while rejecting missing, ambiguous, or stale plan links.
• Add regression tests in est/gh-aw-plan-lifecycle.test.ts and est/gh-aw-activation-finalization.test.ts covering matching revisions, newer unaccepted revisions, missing/ambiguous/stale links, and phased implementation acceptance.

Closes #2206

[github-actions]

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 04f4140

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status	Check	Details
✅	Single commit	1 commit — clean history
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	0 active Copilot thread(s) resolved (1 outdated skipped)
❌	CI passing	11 check(s) still running

Files Changed (6 files, +163 −8)

File	+/−
test/gh-aw-activation-finalization.test.ts	+23 −1
test/gh-aw-activation-label-provisioning.test.ts	+5 −1
test/gh-aw-activation-summary-outcomes.test.ts	+5 −1
test/gh-aw-plan-lifecycle.test.ts	+85 −2
workflows/shared/squad-activation.mjs	+44 −2
workflows/squad-workflows.manifest.json	+1 −1

Total: +163 −8

---

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

[github-actions]

🟡 Impact Analysis — PR #2222

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	6
Files added	0
Files modified	6
Files deleted	0
Modules touched	2

🎯 Risk Factors

• 6 files changed (6-20 → MEDIUM)
• 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (2 files)

• workflows/shared/squad-activation.mjs
• workflows/squad-workflows.manifest.json

tests (4 files)

• test/gh-aw-activation-finalization.test.ts
• test/gh-aw-activation-label-provisioning.test.ts
• test/gh-aw-activation-summary-outcomes.test.ts
• test/gh-aw-plan-lifecycle.test.ts

---

This report is generated automatically for every PR. See #733 for details.

[Copilot]

🟡 Changes recommended

The SHA parser ignores bulleted acceptance metadata, allowing a present stale digest to bypass validation.

1 open finding

• Acceptance check ignores bulleted Implementation SHA-256 metadata · New

What changed in this PR

Binds implementation acceptance artifacts to the selected plan revision before activation.

Changes:

• Validates plan comment links and optional SHA-256 digests.
• Selects the latest applicable acceptance artifact.
• Adds stale, missing, ambiguous, and phased-acceptance tests.

File	Description
workflows/​shared/​squad-activation.mjs	Adds revision-binding validation.
test/​gh-aw-plan-lifecycle.test.ts	Adds lifecycle regression coverage.
test/​gh-aw-activation-summary-outcomes.test.ts	Updates acceptance fixture links.
test/​gh-aw-activation-label-provisioning.test.ts	Updates acceptance fixture links.
test/​gh-aw-activation-finalization.test.ts	Tests stale acceptance during finalization.

---

_{Review effort: Balanced}