fix(cli): accept registered persistent names in health routing by bradygaster · Pull Request #2165 · github/squad

bradygaster · 2026-10-03T19:37:44Z

What

Fix squad health routing validation to accept both registry IDs and registered persistent_name values. Includes regression coverage and a CLI patch changeset. Three files changed, no workflow or release changes.

Why

Frontend research failed before the agent started because valid registered names such as Frontend Lead were rejected as unknown agents. Backend and queue succeeded because their names match registry IDs ignoring case.

Failing run: https://github.com/octodemo/zava-social-frontend-002/actions/runs/37085867778

Working as cli-dev (CLI Engineer).

How

Add normalized nonempty persistent names to the existing known-reference set. Preserve registry ID support and unknown-reference failures. Regression fixture uses both Frontend Lead and registry ID alpha.

⚠️ Quick Check

If SDK/CLI source files changed: completed the applicable Changeset step below (npx changeset add / .changeset/*.md, direct CHANGELOG.md entry for maintainers, or skip-changelog label for no user-facing changes)

PR Readiness Checklist

The PR readiness bot will validate these automatically after push.
Check each item before requesting review. See CONTRIBUTING.md for full details.

Branch & Commit

Branch created from dev (not main)
Branch is up to date with dev (git fetch upstream && git rebase upstream/dev)
Verified diff contains only intended changes (git diff --cached --stat)
PR is not in draft mode (mark ready when checks pass)
Commit history is clean (squash fixups before review)

Build & Test

npm run build passes
npm test passes (all tests green)
npm run lint passes (type check clean)
npm run lint:eslint passes
For migration PRs (>20 files): include test output summary in PR description

Exact local validation results (Microsoft npm proxy configured):

npm test -- --run test/cli/health-command.test.ts: blocked; vitest unavailable.
$env:SKIP_BUILD_BUMP='1'; npm run build: blocked; tsc unavailable.
git diff --check origin/dev...HEAD: passed.
Previous dependency restoration failed because required dependency versions were unavailable through the configured proxy; dependency files were not changed.
Full test suite, type check, and ESLint not run due to unavailable dependencies.
Automated pre-fix red / post-fix green proof remains unverified and required before merge.

Changeset

Changeset added via npx changeset add (if packages/squad-sdk/src/ or packages/squad-cli/src/ changed)
Or direct CHANGELOG.md entry (maintainers only — write-protected for external contributors)
Or skip-changelog label applied (if no user-facing changes)

Changeset authored directly: .changeset/cli-health-persistent-routing.md.

Docs

README section updated (if new feature/module)
Docs feature page (if new user-facing capability)

Bug fix, not a new feature/module. User-facing release note is included in the changeset.

Exports

package.json subpath exports updated (if new module)

N/A: no SDK changes or new modules.

Breaking Changes

None.

Waivers

No merge waiver requested. Draft captures the bounded fix; build/test validation and regression proof remain required before merge. Publishing a patched CLI and updating the client version pin are not included.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-10-03T19:37:58Z

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 035c230

PR Scope: 📦🔧 Mixed (product + infrastructure)

⚠️ 2 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	Changeset file found
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	No Copilot review threads
✅	CI passing	All checks passing

Files Changed (3 files, +38 −0)

File	+/−
`.changeset/cli-health-persistent-routing.md`	+5 −0
`packages/squad-cli/src/cli/commands/health.ts`	+6 −0
`test/cli/health-command.test.ts`	+27 −0

Total: +38 −0

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

github-actions · 2026-10-03T19:37:59Z

🟡 Impact Analysis — PR #2165

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	3
Files added	1
Files modified	2
Files deleted	0
Modules touched	3

🎯 Risk Factors

3 files changed (≤5 → LOW)
3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (1 file)

.changeset/cli-health-persistent-routing.md

squad-cli (1 file)

packages/squad-cli/src/cli/commands/health.ts

tests (1 file)

test/cli/health-command.test.ts

This report is generated automatically for every PR. See #733 for details.

Copilot

🔵 Needs a closer look

Build/test validation and required pre-fix red/post-fix green regression proof remain unverified.

0 open findings

What changed in this PR

Fixes squad health routing validation so registered persistent names are accepted alongside registry IDs.

Changes:

Adds normalized, nonempty persistent names to known routing references.
Adds regression coverage using both a persistent name and a registry ID.
Includes a CLI patch changeset.

File	Description
`test/cli/health-command.test.ts`	Adds mixed-reference regression coverage.
`packages/squad-cli/src/cli/commands/health.ts`	Accepts registered persistent names in routing.
`.changeset/cli-health-persistent-routing.md`	Records the CLI patch release note.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Closes github#2165. Merge latest main after independently approved github#2164 standalone-auth workflow fix; no dev promotion or additional product changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Integrate only the approved technical changes from 90c5396, 2385cf7, 0e881f7 and 50e4b3a into the existing main-based 1.0.1 candidate for github#2166, without merging dev history. Resolve canonical conflicts surgically and regenerate package workflows, manifest and compiler-tamper fixtures from the combined main tree. Preserve the github#2165 health fix, root/SDK/CLI 1.0.1 lockstep and SDK floor. SDK runtime, NuGet and historical changesets remain untouched. Build and targeted contracts passed; current-head hosted CI and human review remain required before merge/publication. Closes github#2167 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix(cli): accept persistent names in health routes (#2165) Co-authored-by: brady gaster <bradygaster@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> (cherry picked from commit d2364df) * chore(release): prepare surgical npm v1.0.1 patch Closes #2165. Consume only its approved CLI health patch changeset; preserve historical main fragments and unchanged SDK/NuGet source. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * fix(release): include approved latest-stable activation correction Integrate only the approved technical changes from 90c5396, 2385cf7, 0e881f7 and 50e4b3a into the existing main-based 1.0.1 candidate for #2166, without merging dev history. Resolve canonical conflicts surgically and regenerate package workflows, manifest and compiler-tamper fixtures from the combined main tree. Preserve the #2165 health fix, root/SDK/CLI 1.0.1 lockstep and SDK floor. SDK runtime, NuGet and historical changesets remain untouched. Build and targeted contracts passed; current-head hosted CI and human review remain required before merge/publication. Closes #2167 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: brady gaster <bradygaster@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>

…rough v1.0.1 (#2220) Drain all 76 pending .changeset/*.md fragments on dev into CHANGELOG.md: - Sync the [1.0.1] release entry from main (#2165, #2167) - Expand [1.0.0] and [0.13.1] with pre-release changesets that shipped in those releases - Populate [Unreleased] with post-1.0.1 changesets landed on dev - Remove consumed .changeset/*.md fragment files so scripts/check-changeset-drift.mjs --mode=fail exits 0 Closes #2180 Refs #1273 Co-authored-by: Copilot <Copilot@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5cf0811c-a02a-41a7-ab00-904b6900db7b

fix(cli): accept persistent names in health routes

79948e9

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge branch 'dev' into bradygaster-squad-review-failure

035c230

bradygaster marked this pull request as ready for review October 3, 2026 19:49

bradygaster requested a review from tamirdresher as a code owner October 3, 2026 19:49

Copilot AI balanced review requested due to automatic review settings October 3, 2026 19:49

Copilot started reviewing on behalf of bradygaster October 3, 2026 19:49

View session

Copilot AI reviewed Oct 3, 2026

View reviewed changes

tamirdresher approved these changes Oct 3, 2026

View reviewed changes

tamirdresher merged commit d2364df into dev Oct 3, 2026
18 of 19 checks passed

bradygaster mentioned this pull request Oct 3, 2026

fix(gh-aw): install latest stable Squad CLI by default #2167

Merged

7 of 17 tasks

tamirdresher mentioned this pull request Oct 3, 2026

chore(release): prepare Squad CLI/SDK 1.0.1 #2166

Merged

Navigation Menu

Repository navigation

fix(cli): accept registered persistent names in health routing - #2165

fix(cli): accept registered persistent names in health routing#2165
tamirdresher merged 2 commits into
devfrom
bradygaster-squad-review-failure

bradygaster commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bradygaster commented Oct 3, 2026

What

Why

How

⚠️ Quick Check

PR Readiness Checklist

Branch & Commit

Build & Test

Changeset

Docs

Exports

Breaking Changes

Waivers

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛫 PR Readiness Check

⚠️ 2 item(s) to address before review

Files Changed (3 files, +38 −0)

Uh oh!

github-actions Bot commented Oct 3, 2026

🟡 Impact Analysis — PR #2165

📊 Summary

🎯 Risk Factors

📦 Modules Affected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Oct 3, 2026 •

edited

Loading