Skip to content

fix(workflows): repair squad-heartbeat 403 on fork PR close #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamirdresher merged 3 commits into from
Oct 2, 2026
Merged

fix(workflows): repair squad-heartbeat 403 on fork PR close #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56e3bd9
fix(workflows): use pull_request_target for squad-heartbeat label repair
Oct 2, 2026
a2cc449
chore: add changeset for squad-heartbeat fork PR label fix
Oct 2, 2026
25f9d36
Merge remote-tracking branch 'origin/dev' into fix/heartbeat-fork-pr-…
Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/2155-heartbeat-fork-pr-labels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@bradygaster/squad-cli": patch
"@bradygaster/squad-sdk": patch
---

Fix `squad-heartbeat.yml`'s "Repair orphaned squad labels" step 403ing when a fork PR closes.

`GITHUB_TOKEN` is forced read-only for `pull_request`-triggered workflow runs originating from a fork, regardless of the workflow's declared `permissions:` block, so `issues.addLabels` was rejected with `403 Resource not accessible by integration`. The trigger is switched to `pull_request_target` across all 5 synced copies (`.github/workflows/`, `templates/workflows/`, `packages/squad-cli/templates/workflows/`, `packages/squad-sdk/templates/workflows/`, `.squad-templates/workflows/`), which runs with base-repo token permissions regardless of fork origin.

This is safe because the `actions/checkout` step never overrides `ref:` (always checks out the base ref, never the fork head), and no step reads or executes anything from the triggering PR's content.
8 changes: 7 additions & 1 deletion .github/workflows/squad-heartbeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,13 @@ on:
# React to completed work or new squad work
issues:
types: [closed, labeled]
pull_request:
# pull_request_target (not pull_request): GITHUB_TOKEN is forced read-only
# for `pull_request` events triggered by a fork, so write steps below
# (addLabels/createComment) 403 on fork PR closes (#2080-class bug).
# Safe here because the checkout step below has no `ref:` override, so it
# always checks out the BASE ref — no fork code or fork-controlled input
# is ever read or executed by this job.
pull_request_target:
types: [closed]

# Manual trigger
Expand Down
8 changes: 7 additions & 1 deletion .squad-templates/workflows/squad-heartbeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ on:
# React to completed work or new squad work
issues:
types: [closed, labeled]
pull_request:
# pull_request_target (not pull_request): GITHUB_TOKEN is forced read-only
# for `pull_request` events triggered by a fork, so write steps below
# (addLabels/createComment) 403 on fork PR closes.
# Safe here because the checkout step below has no `ref:` override, so it
# always checks out the BASE ref — no fork code or fork-controlled input
# is ever read or executed by this job.
pull_request_target:
types: [closed]

# Manual trigger
Expand Down
8 changes: 7 additions & 1 deletion packages/squad-cli/templates/workflows/squad-heartbeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ on:
# React to completed work or new squad work
issues:
types: [closed, labeled]
pull_request:
# pull_request_target (not pull_request): GITHUB_TOKEN is forced read-only
# for `pull_request` events triggered by a fork, so write steps below
# (addLabels/createComment) 403 on fork PR closes.
# Safe here because the checkout step below has no `ref:` override, so it
# always checks out the BASE ref — no fork code or fork-controlled input
# is ever read or executed by this job.
pull_request_target:
types: [closed]

# Manual trigger
Expand Down
8 changes: 7 additions & 1 deletion packages/squad-sdk/templates/workflows/squad-heartbeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ on:
# React to completed work or new squad work
issues:
types: [closed, labeled]
pull_request:
# pull_request_target (not pull_request): GITHUB_TOKEN is forced read-only
# for `pull_request` events triggered by a fork, so write steps below
# (addLabels/createComment) 403 on fork PR closes.
# Safe here because the checkout step below has no `ref:` override, so it
# always checks out the BASE ref — no fork code or fork-controlled input
# is ever read or executed by this job.
pull_request_target:
types: [closed]

# Manual trigger
Expand Down
8 changes: 7 additions & 1 deletion templates/workflows/squad-heartbeat.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,13 @@ on:
# React to completed work or new squad work
issues:
types: [closed, labeled]
pull_request:
# pull_request_target (not pull_request): GITHUB_TOKEN is forced read-only
# for `pull_request` events triggered by a fork, so write steps below
# (addLabels/createComment) 403 on fork PR closes.
# Safe here because the checkout step below has no `ref:` override, so it
# always checks out the BASE ref — no fork code or fork-controlled input
# is ever read or executed by this job.
pull_request_target:
types: [closed]

# Manual trigger
Expand Down
Loading