Skip to content

fix(gh-aw): verify installed workflow source bindings - #2147

Merged
bradygaster merged 3 commits into
devfrom
bradygaster-fix-verify-resource-binding
Oct 2, 2026
Merged

bradygaster merged 3 commits into
devfrom
bradygaster-fix-verify-resource-binding

Conversation

@bradygaster

@bradygaster bradygaster commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • restack onto dev at 8f9e049d, preserving the merged bootstrap provenance hardening and the verifyResource canonicalization
  • reuse one fail-closed workflow source-binding canonicalizer for full install and exported --verify-resource verification
  • require exactly one allowed source: binding in the terminal frontmatter position, bound to installed revision/provenance, then compare the canonical workflow digest with one-way final-newline tolerance
  • keep shared runtime and skill verification as raw exact-byte digest checks without ownership prerequisites
  • add realistic CLI clean-install and mutation coverage; regenerate only the directly affected package/manifest artifacts

Closes #2146

Validation

  • node_modules/.bin/vitest run test/gh-aw-verify-resource.test.ts test/gh-aw-quality.test.ts test/gh-aw-bootstrap-workflow.test.ts — passed, 409 tests
  • node_modules/.bin/vitest run test/gh-aw*.test.ts — passed, 1,985 tests across 29 files
  • npm run lint plus changed-file ESLint — passed
  • npm run gh-aw:integrity:write && npm run gh-aw:integrity:check — passed
  • full install verification regressions in test/gh-aw-quality.test.ts — passed
  • clean consumer strict compile after approved manifest seed — passed, Compiled 8 workflows: 8 succeeded, 2 warnings; only the documented pull_request_target and slash-command/bot diagnostics
  • npm run build — passed
  • git diff --check — passed
  • exact-head hosted CI at db27e598f4875900fdb6f34a62ef12999d76d266 — all required checks passed

Dependency restoration through the required package proxy remained unreliable, so local validation used an existing complete dependency tree from another isolated Squad worktree; no dependency or lockfile changes are included.

Security review

Independent security rereview of the restacked diff found no vulnerabilities. No new secret, permission, action, checkout, or workflow-trigger surface is introduced.

Copilot’s original valid final-newline finding remains fixed and its thread resolved. After restacking, Copilot reviewed all three latest commits, including the regenerated manifest, and reported no significant bugs, security issues, or logic errors.

Scope exclusions

  • no change to intentional roles: all router behavior
  • no generic agentic-workflows scaffold registration
  • no merge requested or performed

Copilot AI balanced review requested due to automatic review settings October 2, 2026 11:13
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2147

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 6
Files added 2
Files modified 4
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 6 files changed (6-20 → MEDIUM)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (5 files)
  • .changeset/fail-closed-gh-aw-resource-verification.md
  • workflows/package/squad-bootstrap.md
  • workflows/shared/squad-install-verifier.mjs
  • workflows/squad-bootstrap.md
  • workflows/squad-workflows.manifest.json
tests (1 file)
  • test/gh-aw-verify-resource.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit db27e59

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved All 1 Copilot thread(s) resolved
✅ CI passing All checks passing

Files Changed (6 files, +201 −28)

File +/−
.changeset/fail-closed-gh-aw-resource-verification.md +8 −0
test/gh-aw-verify-resource.test.ts +147 −0
workflows/package/squad-bootstrap.md +1 −1
workflows/shared/squad-install-verifier.mjs +40 −22
workflows/squad-bootstrap.md +1 −1
workflows/squad-workflows.manifest.json +4 −4

Total: +201 −28


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@bradygaster

Copy link
Copy Markdown
Collaborator Author

@copilot review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Final-newline normalization currently permits an additional blank line to bypass the canonical digest check.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Adds source-binding-aware verification for installed GitHub Agentic Workflow resources.

Changes:

  • Centralizes workflow source-binding and digest verification.
  • Preserves exact-byte checks for runtime and skill resources.
  • Adds CLI mutation and clean-install coverage.
File Description
workflows/​squad-workflows.manifest.json Refreshes generated integrity digests.
workflows/​squad-bootstrap.md Updates the verifier digest.
workflows/​shared/​squad-install-verifier.mjs Implements shared source-binding verification.
workflows/​package/​squad-bootstrap.md Regenerates the packaged bootstrap workflow.
test/​gh-aw-verify-resource.test.ts Tests CLI verification and mutations.
.changeset/​fail-closed-gh-aw-resource-verification.md Records SDK and CLI patch changes.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bradygaster

Copy link
Copy Markdown
Collaborator Author

@copilot review

Copilot AI commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@copilot review

Reviewed the latest two commits; no significant bugs, security issues, or logic errors found. CI build, type-check, and strict compile passed; lint and tests are still running.

bradygaster and others added 3 commits October 2, 2026 05:05
Closes #2146

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #2146

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #2146

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster force-pushed the bradygaster-fix-verify-resource-binding branch from 8b53f70 to db27e59 Compare October 2, 2026 12:09
@bradygaster

Copy link
Copy Markdown
Collaborator Author

@copilot review

Copilot AI commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

@copilot review

Reviewed all three latest commits, including the restacked manifest update; no significant bugs, security issues, or logic errors found. On the current head, build, type-check, strict compile, and workflow checks passed; lint and tests are still running.

@bradygaster
bradygaster merged commit c51281d into dev Oct 2, 2026
29 checks passed
@bradygaster
bradygaster deleted the bradygaster-fix-verify-resource-binding branch October 3, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix verify-resource workflow source binding

3 participants