Repository navigation
fix(gh-aw): verify installed workflow source bindings - #2147
Conversation
🟡 Impact Analysis — PR #2147Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (5 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 3 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | Changeset file found |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | All 1 Copilot thread(s) resolved |
| ✅ | CI passing | All checks passing |
Files Changed (6 files, +201 −28)
| File | +/− |
|---|---|
.changeset/fail-closed-gh-aw-resource-verification.md |
+8 −0 |
test/gh-aw-verify-resource.test.ts |
+147 −0 |
workflows/package/squad-bootstrap.md |
+1 −1 |
workflows/shared/squad-install-verifier.mjs |
+40 −22 |
workflows/squad-bootstrap.md |
+1 −1 |
workflows/squad-workflows.manifest.json |
+4 −4 |
Total: +201 −28
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
|
@copilot review |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Final-newline normalization currently permits an additional blank line to bypass the canonical digest check.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds source-binding-aware verification for installed GitHub Agentic Workflow resources.
Changes:
- Centralizes workflow source-binding and digest verification.
- Preserves exact-byte checks for runtime and skill resources.
- Adds CLI mutation and clean-install coverage.
| File | Description |
|---|---|
workflows/squad-workflows.manifest.json |
Refreshes generated integrity digests. |
workflows/squad-bootstrap.md |
Updates the verifier digest. |
workflows/shared/squad-install-verifier.mjs |
Implements shared source-binding verification. |
workflows/package/squad-bootstrap.md |
Regenerates the packaged bootstrap workflow. |
test/gh-aw-verify-resource.test.ts |
Tests CLI verification and mutations. |
.changeset/fail-closed-gh-aw-resource-verification.md |
Records SDK and CLI patch changes. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@copilot review |
Reviewed the latest two commits; no significant bugs, security issues, or logic errors found. CI build, type-check, and strict compile passed; lint and tests are still running. |
8b53f70 to
db27e59
Compare
|
@copilot review |
Reviewed all three latest commits, including the restacked manifest update; no significant bugs, security issues, or logic errors found. On the current head, build, type-check, strict compile, and workflow checks passed; lint and tests are still running. |

Summary
devat8f9e049d, preserving the merged bootstrap provenance hardening and theverifyResourcecanonicalization--verify-resourceverificationsource:binding in the terminal frontmatter position, bound to installed revision/provenance, then compare the canonical workflow digest with one-way final-newline toleranceCloses #2146
Validation
node_modules/.bin/vitest run test/gh-aw-verify-resource.test.ts test/gh-aw-quality.test.ts test/gh-aw-bootstrap-workflow.test.ts— passed, 409 testsnode_modules/.bin/vitest run test/gh-aw*.test.ts— passed, 1,985 tests across 29 filesnpm run lintplus changed-file ESLint — passednpm run gh-aw:integrity:write && npm run gh-aw:integrity:check— passedtest/gh-aw-quality.test.ts— passedCompiled 8 workflows: 8 succeeded, 2 warnings; only the documentedpull_request_targetand slash-command/bot diagnosticsnpm run build— passedgit diff --check— passeddb27e598f4875900fdb6f34a62ef12999d76d266— all required checks passedDependency restoration through the required package proxy remained unreliable, so local validation used an existing complete dependency tree from another isolated Squad worktree; no dependency or lockfile changes are included.
Security review
Independent security rereview of the restacked diff found no vulnerabilities. No new secret, permission, action, checkout, or workflow-trigger surface is introduced.
Copilot’s original valid final-newline finding remains fixed and its thread resolved. After restacking, Copilot reviewed all three latest commits, including the regenerated manifest, and reported no significant bugs, security issues, or logic errors.
Scope exclusions
roles: allrouter behavioragentic-workflowsscaffold registration