Skip to content

fix(gh-aw): create bootstrap candidate payload parent - #2131

Merged
bradygaster merged 3 commits into
devfrom
bradygaster-fix-bootstrap-candidate-directory
Oct 1, 2026
Merged

bradygaster merged 3 commits into
devfrom
bradygaster-fix-bootstrap-candidate-directory

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

Summary

  • create the isolated bootstrap candidate payload parent before writing the payload
  • preserve .git exclusion and bind provenance to the trusted checkout through gitRoot
  • add realistic missing-directory, source-mutation, and compiled-artifact ordering coverage
  • regenerate only the packaged bootstrap workflow and integrity manifest

Validation

  • npm run gh-aw:integrity:check — passed
  • CI=true npm run build — passed
  • npm test -- test/gh-aw-bootstrap-workflow.test.ts test/gh-aw-cast-validator.test.ts test/gh-aw-quality.test.ts test/gh-aw-install-staging.test.ts test/gh-aw-review-workflow.test.ts test/gh-aw-review-guard.test.ts test/gh-aw-hosted-e2e.test.ts — passed (7 files, 762 tests)
  • gh aw compile squad-bootstrap --strict --approve --no-check-update — passed (1 workflow, 0 warnings)
  • emitted contract inspection — passed; parent creation precedes candidate write, gitRoot: checkout retained, .git exclusion retained
  • independent trust-boundary review — passed with no blocking findings
  • git diff --check — passed

Part of #2128

Part of #2128

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings October 1, 2026 15:43
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2131

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 5
Files added 0
Files modified 5
Files deleted 0
Modules touched 2

🎯 Risk Factors

  • 5 files changed (≤5 → LOW)
  • 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (4 files)
  • .changeset/bright-gh-aw-central-ops.md
  • workflows/package/squad-bootstrap.md
  • workflows/squad-bootstrap.md
  • workflows/squad-workflows.manifest.json
tests (1 file)
  • test/gh-aw-bootstrap-workflow.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit fe46d3d

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status Check Details
❌ Single commit 3 commits — consider squashing before review
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present Changeset file found
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
✅ CI passing All checks passing

Files Changed (5 files, +70 −4)

File +/−
.changeset/bright-gh-aw-central-ops.md +1 −1
test/gh-aw-bootstrap-workflow.test.ts +64 −0
workflows/package/squad-bootstrap.md +1 −0
workflows/squad-bootstrap.md +1 −0
workflows/squad-workflows.manifest.json +3 −3

Total: +70 −4


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused fix preserves trust boundaries and includes mutation-proven compiled-workflow coverage.

Review effort: Balanced
Findings: None

What changed in this PR

Fixes bootstrap validation when the isolated candidate lacks the payload’s parent directory.

Changes:

  • Creates the payload directory before writing.
  • Adds mutation and compiled-artifact regression coverage.
  • Regenerates packaged workflow integrity metadata.
File Description
workflows/​squad-bootstrap.md Creates the candidate payload parent.
workflows/​package/​squad-bootstrap.md Regenerates the packaged workflow.
workflows/​squad-workflows.manifest.json Updates integrity digests.
test/​gh-aw-bootstrap-workflow.test.ts Covers directory creation, ordering, and provenance.
.changeset/​bright-gh-aw-central-ops.md Documents the bootstrap fix.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bradygaster
bradygaster merged commit 261d140 into dev Oct 1, 2026
18 checks passed
@bradygaster
bradygaster deleted the bradygaster-fix-bootstrap-candidate-directory branch October 3, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants