Repository navigation
fix(gh-aw): make Squad Review safe outputs first-install safe - #2104
Merged
Merged
Conversation
Closes #2103 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
🟡 Impact Analysis — PR #2104Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedroot (3 files)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
Contributor
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 2 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | 0 active Copilot thread(s) resolved (1 outdated skipped) |
| ✅ | CI passing | All checks passing |
Files Changed (4 files, +232 −15)
| File | +/− |
|---|---|
test/gh-aw-review-workflow.test.ts |
+133 −2 |
workflows/package/squad-review.md |
+49 −6 |
workflows/squad-review.md |
+49 −6 |
workflows/squad-workflows.manifest.json |
+1 −1 |
Total: +232 −15
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The fallback does not distinguish a genuine first install from an established installation with a missing base guard.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds first-install fallback loading for Squad Review guards while retaining base-branch preference.
Changes:
- Adds immutable workflow-SHA guard checkouts and fallback loading.
- Tests fallback, base precedence, and invalid-base failure.
- Regenerates packaged workflow and manifest digest.
| File | Description |
|---|---|
workflows/squad-review.md |
Defines guard fallback behavior. |
workflows/package/squad-review.md |
Regenerates packaged workflow. |
test/gh-aw-review-workflow.test.ts |
Adds compiled-loader regression coverage. |
workflows/squad-workflows.manifest.json |
Updates packaged workflow hash. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes #2103 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
github.workflow_shaguard only when the base path is absent on a first-install PRsafe_outputsloader against both hosted fixture head SHAs and regenerate the packaged workflow manifest hashHosted reproduction evidence
edd6fbf0f84334ff086ed2bc8bbfed5503fdd56f9a898b5182ca432b62bef26dbf1f9022dd1d256bValidation
npm test -- --run test/gh-aw-review-workflow.test.ts test/gh-aw-review-guard.test.ts test/gh-aw-quality.test.ts— 313 passednpm run gh-aw:integrity:check— passednpm run build— passednpm run lint— passednpm run lint:eslint -- --quiet— passedtest/cli/cast.test.ts, two cases intest/cli/copilot.test.ts,test/cli/rc.test.ts)Closes #2103