Skip to content

fix: accept valid gh-aw cast genesis state - #2095

Merged
bradygaster merged 1 commit into
devfrom
bradygaster-fix-gh-aw-genesis-validation
Sep 28, 2026
Merged

bradygaster merged 1 commit into
devfrom
bradygaster-fix-gh-aw-genesis-validation

Conversation

@bradygaster

Copy link
Copy Markdown
Collaborator

Summary

  • accept a fresh repository with neither committed casting registry nor history as valid genesis
  • reject a committed state containing exactly one of the two casting files
  • preserve validation and rejection behavior for existing valid and malformed pairs
  • regenerate validator integrity pins across canonical/package workflows and the manifest
  • add live-validator regression coverage for the full genesis/existing-pair matrix

Closes #2067

Validation

  • npm test -- --run test/gh-aw-cast-validator.test.ts test/gh-aw-bootstrap-workflow.test.ts — 151 passed
  • npm test -- --run test/gh-aw-quality.test.ts -t "prepares the materialized Cast validator runner outside the agent prompt" — 1 passed
  • npm run gh-aw:integrity:check — manifest and digests current
  • npm run build — SDK and CLI builds passed
  • strict-compiled canonical and packaged squad + squad-bootstrap using gh aw v0.89.21
  • inspected all four emitted lock files: expected runner marker and validator digest each occur exactly once
  • verified canonical/distributed validator bytes both hash to 0988e04aeef316f4d7a0107c902bbbcf6538b8899b9fffba5f62150717967685

Review

Unit & Contract Tester: APPROVE — no blocking findings.

Copilot AI lite review requested due to automatic review settings September 28, 2026 19:42
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Impact Analysis — PR #2095

Risk tier: 🟡 MEDIUM

📊 Summary

Metric Count
Files changed 9
Files added 0
Files modified 9
Files deleted 0
Modules touched 3

🎯 Risk Factors

  • 9 files changed (6-20 → MEDIUM)
  • 3 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (6 files)
  • workflows/package/squad-bootstrap.md
  • workflows/package/squad.md
  • workflows/shared/squad-cast-validator.mjs
  • workflows/squad-bootstrap.md
  • workflows/squad-workflows.manifest.json
  • workflows/squad.md
scripts (1 file)
  • scripts/validate-gh-aw-cast.mjs
tests (2 files)
  • test/gh-aw-cast-validator.test.ts
  • test/gh-aw-quality.test.ts

This report is generated automatically for every PR. See #733 for details.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit a662811

PR Scope: 🔧 Infrastructure

⚠️ 1 item(s) to address before review

Status Check Details
✅ Single commit 1 commit — clean history
✅ Not in draft Ready for review
✅ Branch up to date Up to date with dev
❌ Copilot review No Copilot review yet — it may still be processing
✅ Changeset present No source files changed — changeset not required
✅ Scope clean No .squad/ or docs/proposals/ files
✅ No merge conflicts No merge conflicts
✅ Copilot threads resolved No Copilot review threads
✅ CI passing All checks passing

Files Changed (9 files, +159 −14)

File +/−
scripts/validate-gh-aw-cast.mjs +35 −2
test/gh-aw-cast-validator.test.ts +78 −2
test/gh-aw-quality.test.ts +4 −1
workflows/package/squad-bootstrap.md +1 −1
workflows/package/squad.md +1 −1
workflows/shared/squad-cast-validator.mjs +35 −2
workflows/squad-bootstrap.md +1 −1
workflows/squad-workflows.manifest.json +3 −3
workflows/squad.md +1 −1

Total: +159 −14


This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

Closes #2067

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster force-pushed the bradygaster-fix-gh-aw-genesis-validation branch from 1e27991 to a662811 Compare September 28, 2026 23:28
@bradygaster
bradygaster merged commit 3c3fcec into dev Sep 28, 2026
18 checks passed
@bradygaster
bradygaster deleted the bradygaster-fix-gh-aw-genesis-validation branch October 3, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Squad bootstrap fails on fresh repositories due to stale validator pin and genesis validation

2 participants