Repository navigation
fix(gh-aw): fail closed on rejected /squad commands - #2093
Conversation
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 4 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ✅ | CI passing | All checks passing |
Files Changed (19 files, +882 −925)
| File | +/− |
|---|---|
.github/workflows/squad-ci.yml |
+5 −5 |
scripts/gh-aw-hosted-e2e.mjs |
+4 −4 |
test/gh-aw-command-parse.test.ts |
+194 −540 |
test/gh-aw-hosted-e2e.test.ts |
+2 −2 |
test/gh-aw-quality.test.ts |
+35 −45 |
test/gh-aw-retro-workflow.test.ts |
+1 −1 |
test/gh-aw-review-workflow.test.ts |
+2 −2 |
test/gh-aw-security-scan.test.ts |
+1 −1 |
workflows/aw.yml |
+4 −0 |
workflows/package/squad-bootstrap.md |
+1 −1 |
workflows/package/squad-command-router.md |
+102 −0 |
workflows/package/squad.md |
+84 −157 |
workflows/shared/squad-command-contract.mjs |
+235 −0 |
workflows/shared/squad-install-verifier.mjs |
+7 −2 |
workflows/skills/gh-aw-enlistment/SKILL.md |
+3 −3 |
workflows/squad-bootstrap.md |
+1 −1 |
workflows/squad-command-router.md |
+97 −0 |
workflows/squad-workflows.manifest.json |
+19 −4 |
workflows/squad.md |
+85 −157 |
Total: +882 −925
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🟡 Impact Analysis — PR #2093Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
root (11 files)
scripts (1 file)
tests (6 files)
This report is generated automatically for every PR. See #733 for details. |
🏗️ Architectural Review
Automated architectural review — informational only. |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Closes #1824 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #1824 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #1824 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Closes #1824 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
f3c3203 to
ae29f0a
Compare
Implements #1824
Working as agentic-workflows-dev (Agentic Workflows Engineer).
Summary
workflow_dispatchparsing in one deterministic runtime moduleValidation
npx vitest run test/gh-aw-command-parse.test.ts test/gh-aw-quality.test.ts test/gh-aw-review-workflow.test.ts test/gh-aw-bootstrap-workflow.test.ts test/gh-aw-enlistment-skill.test.ts test/gh-aw-hosted-e2e.test.ts test/gh-aw-retro-workflow.test.ts test/gh-aw-security-scan.test.ts— 654 passednpx eslint test/gh-aw-command-parse.test.ts test/gh-aw-quality.test.ts test/gh-aw-review-workflow.test.ts test/gh-aw-enlistment-skill.test.ts test/gh-aw-hosted-e2e.test.ts test/gh-aw-implement-workflow.test.ts test/gh-aw-security-scan.test.ts scripts/gh-aw-hosted-e2e.mjs— passednpm run gh-aw:integrity:check— passedSKIP_BUILD_BUMP=1 npm run build— passedcore.setFailed, trusted workflow-SHA checkout, and dispatch tosquad.lock.ymlCompile security review
The clean installed-layout compile reported the package's existing restricted secrets (
SQUAD_GITHUB_APP_PRIVATE_KEY,SQUAD_GITHUB_TOKEN) and existing pinnedbradygaster/squad/.github/actions/squad-initaction because the evidence workspace had no prior gh-aw manifest. This PR adds or changes none of those entries; they remain SHA-pinned/unchanged.No changeset is required: this changes gh-aw workflow/runtime resources, package validation, install guidance, and tests—not
packages/squad-cli/src/orpackages/squad-sdk/src/.