[bradygaster]

Summary

• align the shared planning ontology and workflow guidance with the deterministic lifecycle validator
• require command-only nonterminal Next action values with explanation in separate fields
• recognize /squad plan activate and realistic Activation | ✅ Done — ... terminal lifecycle output
• extend idempotent terminal repair to granular activation artifacts and commands
• add live acceptance/activation regression bodies plus a mutation reproducing the rejected implementation-acceptance output

Closes #2051

Working as agentic-workflows-dev (Agentic Workflows Engineer).

Validation

• npm test -- --run test/gh-aw-lifecycle-upsert.test.ts test/gh-aw-plan-lifecycle.test.ts test/gh-aw-quality.test.ts — 309 passed
• npx eslint test/gh-aw-lifecycle-upsert.test.ts test/gh-aw-plan-lifecycle.test.ts test/gh-aw-quality.test.ts
• npm run build
• gh aw compile squad --strict --approve --no-check-update in a consumer-style .github/workflows layout; inspected emitted squad.lock.yml for upsert_lifecycle_state, repair_activated_lifecycle, /squad plan activate, and safe-output job wiring

Scope

No package source, dependency, release-version, or command-surface changes; no changeset required.

[github-actions]

🟡 Impact Analysis — PR #2052

Risk tier: 🟡 MEDIUM

📊 Summary

Metric	Count
Files changed	6
Files added	0
Files modified	6
Files deleted	0
Modules touched	2

🎯 Risk Factors

• 6 files changed (6-20 → MEDIUM)
• 2 modules touched (2-4 → MEDIUM)

📦 Modules Affected

root (3 files)

• workflows/shared/squad-planning-ontology.md
• workflows/shared/squad.md
• workflows/squad.md

tests (3 files)

• test/gh-aw-lifecycle-upsert.test.ts
• test/gh-aw-plan-lifecycle.test.ts
• test/gh-aw-quality.test.ts

---

This report is generated automatically for every PR. See #733 for details.

[github-actions]

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit fa661c8

PR Scope: 🔧 Infrastructure

⚠️ 2 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
✅	Branch up to date	Up to date with dev
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
✅	Copilot threads resolved	0 active Copilot thread(s) resolved (2 outdated skipped)
✅	CI passing	All checks passing

Files Changed (6 files, +163 −20)

File	+/−
test/gh-aw-lifecycle-upsert.test.ts	+130 −2
test/gh-aw-plan-lifecycle.test.ts	+1 −0
test/gh-aw-quality.test.ts	+5 −1
workflows/shared/squad-planning-ontology.md	+6 −1
workflows/shared/squad.md	+17 −15
workflows/squad.md	+4 −1

Total: +163 −20

---

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved activation and terminal-repair issues affect correctness before approval.

Get a fresh assessment by requesting another Copilot review.

Review tier: Lite
Findings: 2

Open (2)

• Accept phased activated artifacts in terminal repair · New
• Keep repair terminal detection aligned with accepted lifecycle formats · New

What changed in this PR

Aligns lifecycle guidance, validation, and terminal repair for acceptance and activation workflows.

Changes:

• Enforces command-only nonterminal Next action values.
• Adds granular activation and terminal lifecycle handling.
• Expands lifecycle and mutation regression coverage.

File	Summary
workflows/​squad.md	Updates lifecycle guidance and activation handling.
workflows/​shared/​squad.md	Extends lifecycle validation and terminal repair logic.
workflows/​shared/​squad-planning-ontology.md	Documents lifecycle field contracts.
test/​gh-aw-quality.test.ts	Verifies compiled workflow contracts.
test/​gh-aw-plan-lifecycle.test.ts	Tests lifecycle guidance and terminal behavior.
test/​gh-aw-lifecycle-upsert.test.ts	Adds lifecycle and repair regression cases.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.