Skip to content

Fix Fact Checker model resolution in plan validation #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradygaster merged 1 commit into from
Sep 15, 2026
Merged

Fix Fact Checker model resolution in plan validation #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/gh-aw-plan-lifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,11 @@ describe('#1757: squad-plan-validate has adversarial teeth', () => {
expect(factChecker).toMatch(/Never emit `RESULT: PASS`, `RESULT: FAIL`/);
});

it('uses automatic model resolution instead of the literal inherited model', () => {
expect(factChecker).toMatch(/^model: auto$/m);
expect(factChecker).not.toMatch(/^model: inherited$/m);
});

it('requires all five DA elements with concrete semantic thresholds', () => {
for (const section of [
'##### Steelman of the opposition',
Expand Down
2 changes: 1 addition & 1 deletion workflows/squad.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2546,7 +2546,7 @@ Full/last: `✅ Done`, state = Activated. Terminal — no next action needed.
## agent: `fact-checker`
---
description: "Produces advisory Devil's Advocate evidence for plan validation"
model: inherited
model: auto
---

Operate only in Fact Checker's Devil's Advocate mode. Review the complete
Expand Down
Loading