Repository navigation
docs: wire nav-wave-1564 pages into navigation - #1580
Conversation
- Merged 5 pending decisions from .squad/decisions/inbox to .squad/decisions.md: - 2026-03-26: CI deletion guard and source tree canary (Booster) - 2026-03-26: Copilot git safety rules (RETRO) - 2026-03-29: Versioning Policy (Flight) - 2026-04-25: Release Process Skill Update (Booster) - 2026-06-24: Restore always-on coordinator inline-dispatch gate (Procedures) - Added orchestration logs for Flight, FIDO, RETRO, Surgeon agents (Session: 2026-07-24T09:20:10.011Z) - Added session log: locked PR merge strategy for 17 open PRs - Deleted merged inbox files (.squad/decisions/inbox/*) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add eight merged docs pages to navigation.ts in their canonical sections: - Guides: Agent Framework Integration (guide/agent-framework-integration) - Security (new section): Security Hardening (features/security-hardening) - Scenarios: Azure Container Apps, AKS Deployment, Production Observability, Production Troubleshooting - Reference: Container Image, State Backend Selection Fix guide count mismatch and expand EXPECTED_GUIDES, EXPECTED_REFERENCE, EXPECTED_SCENARIOS, and EXPECTED_FEATURES in test/docs-build.test.ts so all 8 new pages are covered and no orphan pages remain. Related to #1564 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🛫 PR Readiness Check
PR Scope: 🔧 Infrastructure
|
| Status | Check | Details |
|---|---|---|
| ❌ | Single commit | 5 commits — consider squashing before review |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ❌ | Copilot threads resolved | 1 unresolved Copilot thread(s) — fix and resolve before merging |
| ✅ | CI passing | All checks passing |
Files Changed (2 files, +21 −2)
| File | +/− |
|---|---|
docs/src/navigation.ts |
+14 −0 |
test/docs-build.test.ts |
+7 −2 |
Total: +21 −2
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🟡 Impact Analysis — PR #1580Risk tier: 🟡 MEDIUM 📊 Summary
🎯 Risk Factors
📦 Modules Affecteddocs (1 file)
tests (1 file)
This report is generated automatically for every PR. See #733 for details. |
There was a problem hiding this comment.
Pull request overview
Wires the nav-wave-1564 docs pages into the docs site sidebar (docs/src/navigation.ts) and updates test/docs-build.test.ts fixtures so the Astro build tests correctly expect the new guide/reference/scenario/feature slugs.
Changes:
- Added the new Guide, Scenarios, Reference, and Feature slugs to the
docs-buildfixture expectations. - Added navigation entries for the new pages, including a new “Security” sidebar section.
Show a summary per file
| File | Description |
|---|---|
test/docs-build.test.ts |
Updates expected slug fixtures so docs build output checks include the eight newly added pages. |
docs/src/navigation.ts |
Adds sidebar entries for the new pages and introduces a new “Security” nav section. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
| { | ||
| title: 'Security', | ||
| dir: 'features', | ||
| items: [ | ||
| { title: 'Security Hardening', slug: 'features/security-hardening' }, | ||
| ], | ||
| }, |
✅ Handbook Review — APPROVE TO MERGEReviewed as: Handbook (SDK Usability) Navigation Placement
Reader JourneyGet Started → Concepts → Core/Advanced Features → Infrastructure → Guides → Security → Scenarios → Reference. Cohesive. Security after Guides and before Scenarios is the right location — developers integrate first, harden second, then deploy. Slug ResolutionAll 102 nav slugs resolve to existing `.md` files on disk. Zero orphans. Zero dead slugs. Duplicate / Orphan EntriesNone. Each of the 8 new pages gets exactly one nav entry. #1571/#1573 Nav PreservedNo regressions. Infrastructure section, concepts entries, and get-started changes from those PRs are intact in this diff. New Security Section Warranted?Yes. A single-item "Security" section is intentionally sparse now but the section header immediately signals discoverability to users seeking hardening guidance. Test Fixtures
CI StatusAll blocking checks green. APPROVE TO MERGE. Ship it. |
Summary
Wires the eight pages merged by #1565–#1568 content PRs into the shared
docs/src/navigation.tssidebar and corrects the test fixtures that tracked the guide/reference/scenario/feature counts.Related to #1564
Page Map
guide/agent-framework-integration.mdfeatures/security-hardening.mdscenarios/azure-container-apps.mdscenarios/aks-deployment.mdscenarios/production-observability.mdscenarios/production-troubleshooting.mdreference/container-image.mdreference/state-backend-selection.mdDesign contract followed: integration page in Guides, security in new dedicated Security section, infrastructure/cloud pages in Scenarios, reference material in Reference.
Test Fixtures Updated
test/docs-build.test.ts: Addedagent-framework-integrationtoEXPECTED_GUIDES(fixes count mismatch), addedcontainer-image+state-backend-selectiontoEXPECTED_REFERENCE, added four new scenario slugs toEXPECTED_SCENARIOS, addedsecurity-hardeningtoEXPECTED_FEATURES.docs-build.test.tstests pass locally with these changes.Validation
vitest run test/docs-build.test.ts— ✅ 22/22 pass.mdfiles indocs/src/content/docs/docs/tsconfig.jsonis pre-existing (baseUrl); not introduced by this PRWorking as PAO (DevRel)