Skip to content

fix(security): stop unsafe-git scanner flagging prose in append-only squad logs #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamirdresher merged 1 commit into from
Jul 31, 2026
Merged

fix(security): stop unsafe-git scanner flagging prose in append-only squad logs #1559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions scripts/security-review.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,21 @@ for (const file of jstsFiles) {
}

// 4. Unsafe git operations
//
// Excluded paths: append-only memory/log files that document history and prohibitions.
// These are never executed — they record what happened, not what to do.
// Instruction surfaces (.github/copilot-instructions.md, agent charters, squad.agent.md,
// team.md, routing.md) are deliberately kept in scope: a malicious PR could replace a
// prohibition with an instruction, and we want the scanner to catch that.
// .squad/log/ and .squad/orchestration-log/ are gitignored (never in PR diffs) but
// listed here for documentation completeness.
const UNSAFE_GIT_EXCLUDED_PATHS = [
/^\.squad\/decisions\.md$/,
/^\.squad\/agents\/.+\/history\.md$/,
/^\.squad\/log\//,
/^\.squad\/orchestration-log\//,
];

const GIT_UNSAFE_PATTERNS = [
{ pattern: /git\s+add\s+\./, label: 'git add .' },
{ pattern: /git\s+add\s+-A/, label: 'git add -A' },
Expand All @@ -183,6 +198,7 @@ const GIT_UNSAFE_PATTERNS = [
];

for (const file of changedFiles) {
if (UNSAFE_GIT_EXCLUDED_PATHS.some((p) => p.test(file))) continue;
const added = addedByFile.get(file) || [];
for (const { line, text } of added) {
for (const { pattern, label } of GIT_UNSAFE_PATTERNS) {
Expand Down
Loading