Repository navigation
fix: Squash the Gremlins — 5 bug fixes (#920, #1062, #880, #1107, #905) - #1134
Merged
Merged
Conversation
…detect - #920: Add shell:true to execFile in monitor-teams, monitor-email, retro, decision-hygiene capabilities (fixes Windows spawn EINVAL) - #1062: Bump @github/copilot-sdk from ^0.1.32 to ^0.3.0 (fixes ESM module resolution error) and adapt client.ts for API changes - #880: Add Copilot CLI availability check to squad doctor and preflight checks to monitor-teams/monitor-email capabilities - #1107: Inline team member names in hire confirmation prompt so users can see what they are confirming - #905: Add explicit GitHub repo config support in .squad/config.json (github.owner + github.repo) so platform adapter prefers user-specified repo over auto-detection from origin remote Closes #920, Closes #1062, Closes #880, Closes #1107, Closes #905 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bundles five fixes across the CLI and SDK: Windows compatibility for watch capability process spawning, upgrading @github/copilot-sdk for ESM resolution reliability, improved “doctor” diagnostics, clearer team-hire confirmation UX, and an explicit GitHub repo override in .squad/config.json to avoid incorrect repo detection.
Changes:
- Add
shell: truetoexecFile()in multiplewatchcapabilities to avoid Windowsspawn EINVAL, and add Copilot CLI preflight checks. - Bump
@github/copilot-sdkto^0.3.0and adaptSquadClientintegration for API/type changes. - Prefer
{ github: { owner, repo } }from.squad/config.jsonwhen creating the platform adapter; improve hire confirmation prompt to include member names.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/cli/doctor.test.ts | Updates doctor check count expectation after adding Copilot CLI check. |
| packages/squad-sdk/src/platform/index.ts | Adds .squad/config.json GitHub owner/repo override for platform detection. |
| packages/squad-sdk/src/adapter/client.ts | Adapts Copilot SDK client/session calls for the @github/copilot-sdk@^0.3.0 API/type changes. |
| packages/squad-sdk/package.json | Bumps Copilot SDK dependency and edits SDK package version string. |
| packages/squad-cli/src/cli/shell/index.ts | Improves hire confirmation prompt by listing team member names. |
| packages/squad-cli/src/cli/commands/watch/capabilities/retro.ts | Adds shell: true to execFile() usage for Windows compatibility. |
| packages/squad-cli/src/cli/commands/watch/capabilities/monitor-teams.ts | Adds shell: true and a Copilot CLI preflight check. |
| packages/squad-cli/src/cli/commands/watch/capabilities/monitor-email.ts | Adds shell: true and a Copilot CLI preflight check. |
| packages/squad-cli/src/cli/commands/watch/capabilities/decision-hygiene.ts | Adds shell: true to execFile() usage for Windows compatibility. |
| packages/squad-cli/src/cli/commands/doctor.ts | Adds a “Copilot CLI available” check to squad doctor. |
| package-lock.json | Updates lockfile for @github/copilot-sdk@0.3.0 and transitive dependency changes. |
| .changeset/squash-the-gremlins-sdk.md | Changeset entry for SDK dependency bump + GitHub override support. |
| .changeset/squash-the-gremlins-cli.md | Changeset entry for CLI Windows spawn fix + doctor/preflight + hire UX improvement. |
…p, add tests - Align copilot CLI preflight messages: clarify that the standalone 'copilot' binary is required, mention all 4 dependent capabilities, and suggest --agent-cmd as an override - Revert accidental version bump in squad-sdk/package.json (build script artifact, not an intentional change) - Add 6 tests for the new GitHub config override path in createPlatformAdapter() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The bump-build script had mutated packages/squad-sdk/package.json to 0.9.6-build.5 which was accidentally committed while the lockfile recorded 0.9.6. This mismatch caused npm ci to fail in CI. Reset to 0.9.6 to match the lockfile and satisfy the Prerelease Version Guard policy gate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Squash the Gremlins
Five bug fixes in one pass:
shell: truetoexecFile()in 4 watch capabilities (Windows spawn EINVAL)@github/copilot-sdkto^0.3.0+ adapt client.ts for API changes (ESM resolution error)squad doctor+ preflight in monitor-teams/emailgithub.owner/github.repoin.squad/config.jsonfor repo overrideApproach
copilotviaexecFile()which on Windows cannot resolve bare commands through PATH. Addingshell: truedelegates resolution to the OS shell.@github/copilot-sdk0.1.32 had a broken ESM import. Bumping to 0.3.0 resolves it, with minor type-cast adjustments inclient.tsfor the renamedgitHubTokenfield.checkCopilotCli()doctor check and preflight guards in monitor-teams/email so users get clear guidance when thecopilotCLI is missing.createPlatformAdapter()now reads.squad/config.jsonfor explicitgithub.owner/github.repooverrides before falling back to git remote parsing.Testing
npm run buildpassesvitest run test/cli/doctor.test.tspasses (updated check count assertion)vitest run test/platform-adapter.test.tspasses (6 new tests for config override)Closes #920, Closes #1062, Closes #880, Closes #1107, Closes #905