Skip to content

fix: Squash the Gremlins — 5 bug fixes (#920, #1062, #880, #1107, #905) - #1134

Merged
tamirdresher merged 3 commits into
devfrom
bradygaster/squash-the-gremlins
May 20, 2026
Merged

tamirdresher merged 3 commits into
devfrom
bradygaster/squash-the-gremlins

Conversation

@bradygaster

@bradygaster bradygaster commented May 19, 2026 •

Copy link
Copy Markdown
Collaborator

Squash the Gremlins

Five bug fixes in one pass:

Issue Fix
#920 Add shell: true to execFile() in 4 watch capabilities (Windows spawn EINVAL)
#1062 Bump @github/copilot-sdk to ^0.3.0 + adapt client.ts for API changes (ESM resolution error)
#880 Add Copilot CLI check to squad doctor + preflight in monitor-teams/email
#1107 Inline team member names in hire confirmation prompt
#905 Support explicit github.owner/github.repo in .squad/config.json for repo override

Approach

Testing

  • npm run build passes
  • vitest run test/cli/doctor.test.ts passes (updated check count assertion)
  • vitest run test/platform-adapter.test.ts passes (6 new tests for config override)
  • Pre-existing scheduler test failures on Windows are unchanged by this PR

Closes #920, Closes #1062, Closes #880, Closes #1107, Closes #905

…detect

- #920: Add shell:true to execFile in monitor-teams, monitor-email, retro,
  decision-hygiene capabilities (fixes Windows spawn EINVAL)
- #1062: Bump @github/copilot-sdk from ^0.1.32 to ^0.3.0 (fixes ESM
  module resolution error) and adapt client.ts for API changes
- #880: Add Copilot CLI availability check to squad doctor and preflight
  checks to monitor-teams/monitor-email capabilities
- #1107: Inline team member names in hire confirmation prompt so users
  can see what they are confirming
- #905: Add explicit GitHub repo config support in .squad/config.json
  (github.owner + github.repo) so platform adapter prefers user-specified
  repo over auto-detection from origin remote

Closes #920, Closes #1062, Closes #880, Closes #1107, Closes #905

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 19, 2026 19:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bundles five fixes across the CLI and SDK: Windows compatibility for watch capability process spawning, upgrading @github/copilot-sdk for ESM resolution reliability, improved “doctor” diagnostics, clearer team-hire confirmation UX, and an explicit GitHub repo override in .squad/config.json to avoid incorrect repo detection.

Changes:

  • Add shell: true to execFile() in multiple watch capabilities to avoid Windows spawn EINVAL, and add Copilot CLI preflight checks.
  • Bump @github/copilot-sdk to ^0.3.0 and adapt SquadClient integration for API/type changes.
  • Prefer { github: { owner, repo } } from .squad/config.json when creating the platform adapter; improve hire confirmation prompt to include member names.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/cli/doctor.test.ts Updates doctor check count expectation after adding Copilot CLI check.
packages/squad-sdk/src/platform/index.ts Adds .squad/config.json GitHub owner/repo override for platform detection.
packages/squad-sdk/src/adapter/client.ts Adapts Copilot SDK client/session calls for the @github/copilot-sdk@^0.3.0 API/type changes.
packages/squad-sdk/package.json Bumps Copilot SDK dependency and edits SDK package version string.
packages/squad-cli/src/cli/shell/index.ts Improves hire confirmation prompt by listing team member names.
packages/squad-cli/src/cli/commands/watch/capabilities/retro.ts Adds shell: true to execFile() usage for Windows compatibility.
packages/squad-cli/src/cli/commands/watch/capabilities/monitor-teams.ts Adds shell: true and a Copilot CLI preflight check.
packages/squad-cli/src/cli/commands/watch/capabilities/monitor-email.ts Adds shell: true and a Copilot CLI preflight check.
packages/squad-cli/src/cli/commands/watch/capabilities/decision-hygiene.ts Adds shell: true to execFile() usage for Windows compatibility.
packages/squad-cli/src/cli/commands/doctor.ts Adds a “Copilot CLI available” check to squad doctor.
package-lock.json Updates lockfile for @github/copilot-sdk@0.3.0 and transitive dependency changes.
.changeset/squash-the-gremlins-sdk.md Changeset entry for SDK dependency bump + GitHub override support.
.changeset/squash-the-gremlins-cli.md Changeset entry for CLI Windows spawn fix + doctor/preflight + hire UX improvement.

Comment thread packages/squad-sdk/package.json Resolved
Copilot AI added 2 commits May 19, 2026 13:42
…p, add tests

- Align copilot CLI preflight messages: clarify that the standalone
  'copilot' binary is required, mention all 4 dependent capabilities,
  and suggest --agent-cmd as an override
- Revert accidental version bump in squad-sdk/package.json (build
  script artifact, not an intentional change)
- Add 6 tests for the new GitHub config override path in
  createPlatformAdapter()

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The bump-build script had mutated packages/squad-sdk/package.json to
0.9.6-build.5 which was accidentally committed while the lockfile recorded
0.9.6. This mismatch caused npm ci to fail in CI. Reset to 0.9.6 to match
the lockfile and satisfy the Prerelease Version Guard policy gate.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster requested a review from tamirdresher May 19, 2026 21:29
@tamirdresher
tamirdresher merged commit a3419b5 into dev May 20, 2026
9 of 12 checks passed
@bradygaster
bradygaster deleted the bradygaster/squash-the-gremlins branch August 8, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants