Skip to content

fix(test): add Docker skip guards + stabilize flaky tests under load #677

Closed

Description

@tamirdresher

What

Add Docker availability skip guards and timeout adjustments to fix flaky tests under full-suite load.

Why

Issue #582 reports ~24 intermittent test failures in two categories:

  1. Docker-dependent tests (~15) fail when Docker Desktop isn't running
  2. Timing/resource contention tests (~9) fail under parallel load but pass in isolation

This affects CI reliability for everyone — false negatives on PRs waste reviewer time.

Proposed Fix

  1. Add describe.skipIf(!dockerAvailable) guard to Docker-dependent test files
  2. Increase timeout margins for speed-gate tests
  3. Add retry logic for ENOTEMPTY cleanup errors

Related

Acceptance Criteria

  • Docker-dependent tests skip gracefully when Docker is unavailable
  • Speed-gate tests pass reliably under full parallel load
  • npm test shows 0 flaky failures on 3 consecutive runs

Activity

  1. added
    squadSquad triage inbox — Lead will assign to a member
    type:choreMaintenance, refactoring, cleanup
    on Mar 29, 2026
  2. github-actions commented on Mar 29, 2026

    @github-actions
    Contributor

    📋 Assigned to FIDO (Quality Owner)

    Issue: #677 — fix(test): add Docker skip guards + stabilize flaky tests under load

    FIDO will pick this up in the next Copilot session.

    For Copilot coding agent: If enabled, this issue will be worked automatically.
    Otherwise, start a Copilot session and say:
    FIDO, work on issue #677

  3. github-actions commented on Mar 29, 2026

    @github-actions
    Contributor

    🏗️ Squad Triage — Flight (Lead)

    Issue: #677 — fix(test): add Docker skip guards + stabilize flaky tests under load
    Assigned to: FIDO (Quality Owner)
    Reason: Issue relates to testing/quality work

    @copilot evaluation: No strong capability match — routed to squad member.

    Team roster:

    • Flight (Lead) → label: squad:flight
    • Procedures (Prompt Engineer) → label: squad:procedures
    • EECOM (Core Dev) → label: squad:eecom
    • FIDO (Quality Owner) → label: squad:fido
    • PAO (DevRel) → label: squad:pao
    • CAPCOM (SDK Expert) → label: squad:capcom
    • CONTROL (TypeScript Engineer) → label: squad:control
    • Surgeon (Release Manager) → label: squad:surgeon
    • Booster (CI/CD Engineer) → label: squad:booster
    • GNC (Node.js Runtime) → label: squad:gnc
    • Network (Distribution) → label: squad:network
    • RETRO (Security) → label: squad:retro
    • INCO (CLI UX & Visual Design) → label: squad:inco
    • GUIDO (VS Code Extension) → label: squad:guido
    • Telemetry (Aspire & Observability) → label: squad:telemetry
    • VOX (REPL & Interactive Shell) → label: squad:vox
    • DSKY (TUI Engineer) → label: squad:dsky
    • Sims (E2E Test Engineer) → label: squad:sims
    • Handbook (SDK Usability) → label: squad:handbook
    • Ralph (Work Monitor) → label: squad:ralph
    • @copilot (Coding Agent) → label: squad:copilot

    To reassign, remove the current squad:* label and add the correct one.

  4. added a commit that references this issue on Mar 29, 2026
    9b52aa3
  5. diberry commented on Mar 31, 2026

    @diberry
    Contributor

    🔄 Ralph status: PR #679 addresses this (also covers #582, now closed as duplicate). Needs rebase (behind dev). Small fix — 3 files, Docker skip guard + timeout.

  6. self-assigned this
    on Mar 31, 2026
  7. tamirdresher commented on Mar 31, 2026

    @tamirdresher
    CollaboratorAuthor

    🔄 Claimed by TAMIRDRESHER at 2026-03-31T21:34:52Z

  8. added 2 commits that reference this issue on Mar 31, 2026
    4752e1f
    eda0b2b
  9. tamirdresher commented on Mar 31, 2026

    @tamirdresher
    CollaboratorAuthor

    ✅ PR #723 created — rebased onto current dev + added Docker skip guard to cli/aspire.test.ts

    Changes:

    Testing:

    • ✅ Build passes
    • ✅ Docker tests skip when SKIP_DOCKER_TESTS=1
    • ✅ 2 tests skipped, 14 passed in cli/aspire.test.ts

    PR ready for review.

  10. diberry commented on Mar 31, 2026

    @diberry
    Contributor

    ✅ Status Update — Issue #677

    PR #723 and PR #679 both address this issue:

    Ready for merge.

  11. diberry commented on Mar 31, 2026

    @diberry
    Contributor

    🔄 Ralph status update: PR #723 has team review, all CI green. PR #679 also addresses this.. Labeled \squad:pr-reviewed. Awaiting Dina review.

  12. added a commit that references this issue on Apr 13, 2026
    3055812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

go:needs-researchNeeds investigationsquadSquad triage inbox — Lead will assign to a membertype:choreMaintenance, refactoring, cleanup

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions