Skip to content

Credit EmmittJ for skill system inspiration + create follow-up issues from PR #215 #297

Closed

Description

@bradygaster

Credit EmmittJ's Skill System Contribution

Background

PR #215 by @EmmittJ proposed a comprehensive skill-script model for making Squad's storage layer pluggable. While the PR wasn't merged directly (closed when #162 was cancelled), the design thinking significantly influenced the skill system we shipped in v0.8.21–v0.8.25.

Part 1: Contributors Guide Update

Add EmmittJ to the Contributors Guide (docs/ and any relevant contributor recognition pages) with credit for:

  • Inspiring the .squad/skills/ directory structure and SKILL.md format
  • The skill matching and confidence lifecycle design
  • The vision for extensible, pluggable tool handlers

Reference: PR #215 — "Adds the skill system design proposal (#162)"

Part 2: Follow-Up Issues for Remaining Proposal Items

Create individual issues (credited to EmmittJ's design in PR #215) for these unimplemented features:

  1. Executable skill handler scripts — JS/TS scripts in .squad/skills/{name}/ that replace built-in tool handlers at runtime
  2. SkillScriptLoader — A loader class that discovers, validates, and executes handler scripts with sandboxing
  3. Lifecycle hooks — on_acquire, on_complete, on_error hooks for skill handler lifecycle management
  4. ToolRegistry handler replacement — applySkillHandlers() integration that lets skills override default tool behavior

Each issue should reference PR #215 as the design origin and note that @EmmittJ is welcome to re-submit PRs for any of these if they'd like to implement them directly.

Acceptance Criteria

Activity

  1. github-actions commented on Mar 9, 2026

    @github-actions
    Contributor

    📋 Assigned to PAO (DevRel)

    Issue: #297 — Credit EmmittJ for skill system inspiration + create follow-up issues from PR #215

    PAO will pick this up in the next Copilot session.

    For Copilot coding agent: If enabled, this issue will be worked automatically.
    Otherwise, start a Copilot session and say:
    PAO, work on issue #297

  2. github-actions commented on Mar 9, 2026

    @github-actions
    Contributor

    🏷️ Issue type updated → type:docs

  3. github-actions commented on Mar 9, 2026

    @github-actions
    Contributor

    🏷️ Issue type updated → type:feature

  4. bradygaster commented on Mar 10, 2026

    @bradygaster
    CollaboratorAuthor

    Triage by PAO

    Good news: PR #215 by @EmmittJ influenced the skill system we shipped in v0.8.21–v0.8.25. Ready to credit.

    This issue asks for:

    1. ✅ Add EmmittJ to Contributors Guide — credit for skill system design inspiration
    2. ⏳ Create 4 follow-up issues for unimplemented features from PR Adds the skill system design proposal (#162) #215:
      • Executable skill handler scripts (.squad/skills/{name}/ JS/TS scripts)
      • SkillScriptLoader class
      • Lifecycle hooks (on_acquire, on_complete, on_error)
      • ToolRegistry handler replacement (applySkillHandlers)

    Recommendation: Part 1 (contributor credit) should go in the next release. Part 2 (follow-ups) can be created now, but tag them for future sprints — we want EmmittJ to know we're interested in them without blocking the contributor acknowledgment.

    📌 Per team directive (v0.8.24+): Contributor recognition happens every release. This is ready for the next release cycle.

  5. github-actions commented on Mar 13, 2026

    @github-actions
    Contributor

    ⚠️ No squad member found matching label squad:mcmanus. Check .squad/team.md (or .ai-team/team.md) for valid member names.

  6. github-actions commented on Mar 13, 2026

    @github-actions
    Contributor

    📋 Assigned to PAO (DevRel)

    Issue: #297 — Credit EmmittJ for skill system inspiration + create follow-up issues from PR #215

    PAO will pick this up in the next Copilot session.

    For Copilot coding agent: If enabled, this issue will be worked automatically.
    Otherwise, start a Copilot session and say:
    PAO, work on issue #297

  7. bradygaster commented on Mar 15, 2026

    @bradygaster
    CollaboratorAuthor

    Done! @EmmittJ's SkillScriptLoader contribution has been merged to dev (commit ba8d8f7) and is now part of the runtime. The skill handler system he envisioned in PR #215 is real — agents can now load executable scripts from .squad/skills/ directories. Huge thanks to @EmmittJ for the inspiration and the code. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions