Skip to content

fix: pre-existing test failures across all branches (12 files, 14 tests) #273

Closed

Description

@tamirdresher

Multiple test files fail on every branch (including upstream/main and Brady's dev). These are not regressions from any specific PR — they are pre-existing.

Root Cause Analysis

ENVIRONMENT (2 tests — need Docker)

  • test/cli/aspire.test.ts — Docker not installed, tests already have skip guards
  • test/aspire-integration.test.ts — Needs Docker + OTel + Playwright

CODE MISMATCH (3 tests — API changed, tests not updated)

  • test/otel-provider.test.ts — Module import path or export names changed
  • test/hostile-integration.test.ts — Fixture or component API mismatch
  • test/cli-shell-comprehensive.test.ts — Coordinator/session API evolved

FLAKY TIMING (7 tests — timeouts too tight)

  • test/speed-gates.test.ts — 5s too tight for CLI startup under parallel load
  • test/cli-p0-regressions.test.ts — TerminalHarness 5s timeout insufficient
  • test/journey-*.test.ts (3 files) — ink-testing-library tick timing races
  • test/cli-global.test.ts — Test isolation + timing
  • test/upstream-e2e.test.ts — File I/O timing

Proposed Fixes

  1. Increase TerminalHarness timeouts from 5s to 10s
  2. Increase journey test tick delays from 80ms to 150ms
  3. Add skip guards for Docker-dependent tests
  4. Fix module import paths in otel-provider tests
  5. Verify hostile-integration fixtures exist

Activity

  1. added 3 commits that reference this issue on Mar 9, 2026
    8ace9c6
    d2dc625
    7dcf5b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions