Skip to content

test: upgrade.test.ts still expects casting_policy_version 1.1, template bumped to 1.2 in #1643 #1661

Closed

Description

@omercangumus

Summary

`test/cli/upgrade.test.ts` > `ensureCastingDefaults scaffolds registry.json, policy.json, history.json` hardcodes `casting_policy_version: '1.1'`. #1643 bumped every `casting-policy.json` template mirror to `1.2` (custom universes / descriptive default naming) but didn't touch this assertion. Fails deterministically on `dev` right now, not flaky — hit it on CI for #1660, confirmed identical failure with that PR's diff fully stashed.

Repro

```
npx vitest run test/cli/upgrade.test.ts -t "ensureCastingDefaults scaffolds registry"
```

```
FAIL test/cli/upgrade.test.ts > CLI: upgrade command > ensureCastingDefaults scaffolds registry.json, policy.json, history.json
AssertionError: expected { casting_policy_version: '1.2', …(4) } to have property "casting_policy_version" with value '1.1'
❯ test/cli/upgrade.test.ts:542:20
540| expect(registry).toHaveProperty('agents');
541| const policy = JSON.parse(readFileSync(join(dir, '.squad', 'castin…
542| expect(policy).toHaveProperty('casting_policy_version', '1.1');
```

Fix

One-line: `test/cli/upgrade.test.ts:542`, `'1.1'` → `'1.2'`.

Activity

  1. bradygaster commented on Aug 10, 2026

    @bradygaster
    Collaborator

    Already fixed on dev — assertion at line 542 already expects 1.2. Test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions