Skip to content

Split plan acceptance into scope approval, implementation approval, and execution activation #1656

Closed

Description

@bradygaster

Parent epic: #1648

Outcome

Replace overloaded /squad plan accept semantics with explicit transitions:

  1. /squad plan accept scope
  2. /squad plan accept implementation
  3. /squad plan activate

Requirements

  • Preserve a deliberate compatibility path for /squad plan accept.
  • Require validation for the exact accepted plan revision.
  • Make retries idempotent and prevent duplicate issues/milestones/labels.
  • Record actor, revision, command, and created/updated artifact IDs.
  • Acceptance does not authorize implementation until explicit activation.

Acceptance criteria

  • Each transition has distinct preconditions/postconditions.
  • Scope can be accepted while implementation remains under revision.
  • Artifacts cannot silently drift from the approved revision.
  • Activation can hand off to customer automation without coupling Squad to a specific executor.

Size: M

Activity

  1. added
    squadSquad triage inbox — Lead will assign to a member
    gh-awGitHub Agentic Workflows integration
    on Aug 8, 2026
  2. bradygaster commented on Aug 8, 2026

    @bradygaster
    CollaboratorAuthor

    E2E evidence: revision links work, but accepted sizing summary drifts

    Tested SHA: 47e04dc73663cba40b47f00dd8e2ac42c37f6419
    Consumer/root: https://github.com/bradygaster/squad-planning-e2e/issues/2

    Reproduction

    Run validation, accept scope, accept implementation, activate, then repeat activation.

    Expected

    Acceptance records the exact validated revision and metadata without drift; retry creates no duplicate artifacts.

    Actual

    • Positive: scope acceptance links the exact program run; implementation acceptance links the exact implementation and scope-acceptance runs.
    • Positive: repeated activation detected all 18 existing issues and created zero duplicates.
    • Defect: the implementation acceptance says XS×1, S×3, M×9, L×9 (22 total) for an 18-task plan. Validation and actual activated labels agree on XS×0, S×2, M×8, L×8 (18 total).

    Acceptance comment: https://github.com/bradygaster/squad-planning-e2e/issues/2#issuecomment-5224830600

    Impact

    The locked acceptance record contains metadata that does not describe the accepted revision, undermining auditability even though the linked revisions and retry behavior are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gh-awGitHub Agentic Workflows integrationpriority:p1This sprintsquadSquad triage inbox — Lead will assign to a membertype:featureNew capability

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions