Repository navigation
history-shadow.ts uses invalid \Z regex anchor, duplicating headers and collapsing separators #1500
Description
Summary
packages/squad-sdk/src/agents/history-shadow.ts builds section-boundary regular expressions with \Z at two call sites. JavaScript RegExp does not support \Z as an end-of-string anchor, so it is interpreted as a literal Z.
Impact
- Appending to the terminal
Referencessection does not find the existing section and adds a second## Referencesheader. - Appending to non-terminal sections finds the next header but collapses the blank-line separator before it.
- The read/parse path contains the same invalid anchor and needs equivalent correction.
Evidence
packages/squad-sdk/src/agents/history-shadow.ts, write path near line 236packages/squad-sdk/src/agents/history-shadow.ts, read/parse path near line 331packages/squad-sdk/src/state/io/history-io.tsalready documents and avoids this anchor through header-position splitting- Draft PR test(memory): characterization baselines for #1309 (research, not closing) #1499 characterizes the current behavior without changing production code
Suggested approach
Replace the invalid anchor with a JavaScript-correct end-of-string strategy, or reuse the header-position splitting approach already implemented in history-io.ts so both paths share one correct boundary implementation.
Acceptance criteria
- Appending to terminal
Referencesinserts the entry under the existing header without duplicating it. - Appending to non-terminal sections preserves the blank line between sections.
- The read/parse path handles terminal sections correctly.
- Characterization tests in test(memory): characterization baselines for #1309 (research, not closing) #1499 are updated from current-bug expectations to corrected behavior when this fix lands.
- Existing history-shadow and state I/O tests remain green.
Activity
github-actions commentedon Jul 18, 2026
📋 Assigned to Surgeon (Release Manager)
Issue: #1500 — history-shadow.ts uses invalid \Z regex anchor, duplicating headers and collapsing separators
Surgeon will pick this up in the next Copilot session.
github-actions commentedon Sep 10, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 10, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 11, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 11, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 11, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 11, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 11, 2026
🔄 Ralph — Auto-Triage
Assigned to: Procedures
Reason: Matched module path "src/agents/" to primary owner "Procedures 🧠"
Source: module-ownership
github-actions commentedon Sep 13, 2026
🔄 Ralph — Auto-Triage
Assigned to: architect
Reason: No module, routing, or role keyword match — routed to Lead/Architect
Source: lead-fallback
github-actions commentedon Sep 24, 2026
📋 Assigned to sdk-runtime-dev (SDK Runtime Engineer)
Issue: #1500 — history-shadow.ts uses invalid \Z regex anchor, duplicating headers and collapsing separators
sdk-runtime-dev will pick this up in the next Copilot session.
fix(sdk): replace invalid \Z regex anchor in history-shadow (#2374)