Skip to content

ci: pin actions in squad-insider-release.yml template to commit SHAs #1462

Open

Description

@omercangumus

Follow-up from #1442. The squad-insider-release.yml template was left out of the SHA pinning work under a documented waiver, so its action references are still tag-based.

Once the waiver is no longer needed, the actions in this template should be pinned to full-length commit SHAs like the rest of the workflows, with trailing version comments for readability. Dependabot is already set up for weekly SHA maintenance, so it will pick this file up once pinned.

Activity

  1. bradygaster commented on Aug 23, 2026

    @bradygaster
    Collaborator

    Triage note — this is NOT fixed. Flagging because it was nearly closed as shipped.

    #1442 (security(ci): pin third-party GitHub Actions to full commit SHAs) pinned the actions in .github/workflows/ — the repo's own CI. For example .github/workflows/squad-insider-publish.yml is now correctly on actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1.

    It did not touch the shipped templates. All four copies still use floating tags:

    Path checkout setup-node
    .squad-templates/workflows/squad-insider-release.yml @v4 @v4
    templates/workflows/squad-insider-release.yml @v4 @v4
    packages/squad-cli/templates/workflows/squad-insider-release.yml @v4 @v4
    packages/squad-sdk/templates/workflows/squad-insider-release.yml @v4 @v4

    These are the files squad init writes into consumer repos. So the unpinned-action exposure was removed from our repo and left in place for every downstream user — which is the worse half, since those repos inherit the risk without having chosen it.

    Two things this suggests beyond the original scope:

    1. Whatever check keeps .github/workflows/ pinned should cover **/templates/**/*.yml too, or this re-diverges on the next template edit.
    2. The four copies are byte-identical and drift independently — same duplication problem tracked elsewhere in the template set.

    Verified against origin/dev on 2026-08-23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    wave1:P7Wave 1 PR group P7wave:1-nextWave 1 — immediate next sprint

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions