Skip to content

[External State] squad internalize copies back without external-dir cleanup #1401

Open

Description

@dat-intellis

Summary

squad internalize copies state from external dir back to local .squad but does not clean external dir afterwards.

Evidence

  • Copy loop in internalize:
    • packages/squad-cli/src/cli/commands/externalize.ts:152-168
  • No delete/cleanup of external source entries after copy.
  • Delete calls in file are used in other contexts (externalize move + config cleanup), not external-dir cleanup in internalize.

Expected

If semantics are “move back”, external source should be cleaned; otherwise behavior/docs should explicitly define copy-back semantics.

Actual

Behavior is copy-back without external cleanup.

Activity

  1. added
    stalled-initiativeWork area that was started but never completed — cut, close, finish, or reprioritize
    on Aug 30, 2026
  2. bradygaster commented on Sep 24, 2026

    @bradygaster
    Collaborator

    Keeping this open as a product-semantics decision, not folding it into the completed #1402 integration tracker. Current behavior is copy-back and was documented in merged PR #1466. Before implementation, decide explicitly whether internalize means move (clean external state) or copy (retain it), then align acceptance criteria, safety behavior, and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stalled-initiativeWork area that was started but never completed — cut, close, finish, or reprioritizewave1:P2Wave 1 PR group P2wave:1-nextWave 1 — immediate next sprint

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions