Skip to content

bug: comms-teams.ts ignores SQUAD_HOME — Teams OAuth tokens always written to ~/.squad/ #1279

Closed

Description

@dat-intellis

Summary

The Microsoft Teams adapter (packages/squad-sdk/src/platform/comms-teams.ts) hardcodes ~/.squad/ as the token storage directory. It does not use resolveSquadHome() (added in #1038 / PR #1041), so SQUAD_HOME overrides are silently ignored.

Reproduction

export SQUAD_HOME=/mnt/synced-drive/.squad
squad teams auth  # authenticates successfully
ls ~/.squad/teams-tokens-*.json   # token written here — WRONG
ls /mnt/synced-drive/.squad/teams-tokens-*.json  # nothing here

Expected behavior

Token files should be stored under resolveSquadHome(), which respects SQUAD_HOME when set and falls back to ~/.squad/ otherwise.

Actual behavior

Token files are unconditionally written to ~/.squad/, regardless of SQUAD_HOME.

Relevant source: packages/squad-sdk/src/platform/comms-teams.ts line 57:

const SQUAD_DIR = join(homedir(), '.squad');

resolveSquadHome() is already exported from resolution.ts (added in #1038 / PR #1041) and is the correct replacement.

Environment

  • squad-sdk: v0.10.0
  • OS: any (most impactful on Linux with custom XDG paths or shared mounts)
  • Node: v22+

Related: Issue #1038 (SQUAD_HOME feature), PR #1041 (added resolveSquadHome). See also companion issue for capabilities.ts (same root cause).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triagedIssue has been triagedwave:1-nextWave 1 — immediate next sprint

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions