Repository navigation
Changes to last year format - #133
Merged
Merged
Conversation
keithamus
approved these changes
Jan 15, 2020
keithamus
left a comment
keithamus
left a comment
Contributor
There was a problem hiding this comment.
Looks good 👍 I think 18 months is a good cutoff.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change increases the month cutoff from 12 to 18 months meaning that months > 12 < 18 will be displayed as
'x months ago'instead of'last year'. Months >18 will be displayed as'x years ago'.This is to prevent
'last year'showing up in January 2020 and you are viewing a<time-ago>element set to November 2018. Since it's more than 12 months we'll round it down to 1 year, parse it as a years ago andIntl.RelativeTimeFormatwill format it as'last year'.Ref: https://github.com/github/github/issues/132315