Skip to content

Allow trailing commas - #18

Merged
keithamus merged 1 commit into
github:masterfrom
artemsaveliev:patch-1
Nov 30, 2022
Merged

keithamus merged 1 commit into
github:masterfrom
artemsaveliev:patch-1

Conversation

@artemsaveliev

Copy link
Copy Markdown
Contributor

Followup to #1 so we can get trailing commas

@koddsson koddsson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keithamus keithamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ,

@keithamus
keithamus merged commit 96dd4c9 into github:master Nov 30, 2022
@keithamus

Copy link
Copy Markdown
Contributor

This is now in @github/prettier-config@0.0.5

@fisker

fisker commented Dec 1, 2022

Copy link
Copy Markdown

FYI: Prettier is going change it to "all" in v3. prettier/prettier#11465

@keithamus

Copy link
Copy Markdown
Contributor

Thanks for the callout @fisker. We should do the same!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants