You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
asciidoctor include:: doesn't seem to be usable for github repos #335
changed the title [-]include:: doesn't seem to be usable for github repos[/-][+]asciidoctor include:: doesn't seem to be usable for github repos[/+]on Jul 17, 2014
Due to potential security issues, include:: is not supported by GitHub at this time. We don't know if or when we'll add such a feature, but I've added your request to our internal feature request list.
@gjtorikian re inherent insecurity of include directives, completely understable, given how my background includes PHP ;).
Nevertheless, I think properly pre-sanitized includes limited to only, say, files in the same repo (or same user's repos) would be safe enough, so 👍 on the add.
We need to do some planning and negotiating first, then we can possibly move forwards with an implementation. The limitations have to do as much about security as they are technical.
Activity
[-]include:: doesn't seem to be usable for github repos[/-][+]asciidoctor include:: doesn't seem to be usable for github repos[/+]gjtorikian commentedon Jul 19, 2014
Due to potential security issues,
include::is not supported by GitHub at this time. We don't know if or when we'll add such a feature, but I've added your request to our internal feature request list.mikolak-net commentedon Jul 20, 2014
@gjtorikian re inherent insecurity of
includedirectives, completely understable, given how my background includes PHP ;).Nevertheless, I think properly pre-sanitized includes limited to only, say, files in the same repo (or same user's repos) would be safe enough, so 👍 on the add.
mojavelinux commentedon Sep 13, 2014
We're tracking this request from the Asciidoctor side.
asciidoctor/asciidoctor#1088
We need to do some planning and negotiating first, then we can possibly move forwards with an implementation. The limitations have to do as much about security as they are technical.