svg images in ReST documents omitted due to use of <object> tag filtering #264

Activity

1. bkeepers commented on Mar 7, 2014

   

   bkeepers

   on Mar 7, 2014

   Contributor

   More actions

   What is the output generate? We definitely can't allow object due to security and usability concerns.
2. mr-c commented on Mar 7, 2014

   

   mr-c

   on Mar 7, 2014

   Author

   More actions

   $ github-markup README.rst
   [...]
   <a class="reference external image-reference" href="
   https://scan.coverity.com/projects/621"><object data="
   https://scan.coverity.com/projects/621/badge.svg"
   type="image/svg+xml">Coverity Scan Build Status</object></a>
   [...]
   

   On Fri, Mar 7, 2014 at 5:15 PM, Brandon Keepers notifications@github.comwrote:

   What is the output generate? We definitely can't allow object due to
   security and usability concerns.

   Reply to this email directly or view it on GitHubhttps://github.com//issues/264#issuecomment-37073809
   .
3. bkeepers commented on Mar 8, 2014

   

   bkeepers

   on Mar 8, 2014

   Contributor

   More actions

   Historically, I think object was the most reliable way to embed SVG, but now it looks like the img tag works in all browsers. I don't know what it would take to get ReST to generate an img tag, but that's what needs done.
4. myint

   added a commit that references this issue on Mar 8, 2014

   Remove this for now

   ...

   57d8d4f
5. mr-c commented on Mar 10, 2014

   

   mr-c

   on Mar 10, 2014

   Author

   More actions

   I've filed a bug with a patch to docutils to fix this: https://sourceforge.net/p/docutils/bugs/247/
6. bkeepers commented on Mar 10, 2014

   

   bkeepers

   on Mar 10, 2014

   Contributor

   More actions

   Awesome. My python is not strong, but I'm guessing it would be possible to implement this in the GitHubHTMLTranslator in rest2html for now. Pull requests are welcome!
7. neogeographica

   added a commit that references this issue on Mar 29, 2014

   Revert "use SVG badges in README... more readable"

   ...

   34a981e
8. myint commented on Apr 12, 2014

   

   myint

   on Apr 12, 2014

   More actions

   A temporary hack to workaround this is to put some junk at the end of the URL to fool docutils.

   myint/perceptualdiff@6e769cb#diff-88b99bb28683bd5b7e3a204826ead112R15
9. gjtorikian

   closed this as completedin #287on Apr 16, 2014
10. myint

    added a commit that references this issue on Apr 18, 2014

    Try removing SVG workaround in readme

    ...

    fb664be