Repository navigation
image not respecting alignement with png in .rst #1760
Description
Activity
It seems that alignment also doesn't work for URLs with parameters (
?foo=1) after the.svg.Stale issue message
This thread might be stale, but the issue is still there.
@zkoppert please reopen
Reopening this issue based on investigation in #1222. The bug is confirmed and reproducible — RST image alignment works for SVGs but not for PNGs (or any non-SVG image type).
Root cause: Our
GitHubHTMLTranslatorinrest2htmlhas customdepart_imagehandling for SVGs that rebuilds the<img>tag and copies thealignattribute directly. Non-SVG images fall through to docutils' defaultHTMLTranslator, which converts:align:toclass="align-right"— and the sanitization pipeline stripsclassattributes. The same issue affects:width:and:height:, which get converted tostyleattributes that are also stripped.Proposed fix: Update
GitHubHTMLTranslatorto emitalign,width, andheightas HTML attributes for all images (not just SVGs). These attributes are explicitly in the sanitizer's allowlist and are safe — they can only express layout, not execute code.
I decided to open a follow-up of this thread as the bug seems to be fixed but fails on some more specific image type.
I try to align the content of my readme.rst file to use as a long description in my pypi release. using the
.. raw::directive is then impossible.A common way to do it (that works on both sphinx and pypi) is:
It seems this is not taken into account when generating .png preview as shown in this gist where the .svg is correctly aligned and the .png is not.