Repository navigation
DML write sets sql_mode to STRICT ALL TABLES - #191
Merged
Merged
Conversation
Contributor
Author
|
Sent to testing |
Contributor
Author
|
Testing goes well. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storyline: #164
Each DML write forces session
sql_modetoSTRICT_ALL_TABLES.This serves as a safety net in case the server's
sql_modeis not strict.gh-ost's mode should be strict because it just copies values around, so there should not be any case where data is truncated.On interesting potential case is if the user reduces
BIGINTtoINT, orVARCHAR(128)toVARCHAR(64), for example, and some existing values do not fit in reduced column size.This PR will assist the user in avoiding shooting herself in the foot.
gofmt(please avoidgoimports)./build.sh./test.sh