Skip to content

setting time_zone on DML apply - #175

Merged
shlomi-noach merged 1 commit into
masterfrom
apply-dml-tz
Aug 22, 2016
Merged

shlomi-noach merged 1 commit into
masterfrom
apply-dml-tz

Conversation

@shlomi-noach

@shlomi-noach shlomi-noach commented Aug 19, 2016 •

Copy link
Copy Markdown
Contributor

Storyline: #161

This addresses the time_zone setting by applying a sessiontime_zone for each and every DML applied, within same transaction

cc @dveeden

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via ./test.sh

@shlomi-noach

Copy link
Copy Markdown
Contributor Author

Obsoletes #165

@shlomi-noach

Copy link
Copy Markdown
Contributor Author

@dveeden are you able to test this branch on your side?

@shlomi-noach

Copy link
Copy Markdown
Contributor Author

Insofar this passes tests on my side; however the problem never manifested on my side in the first place. I'll only merge this on Monday, pending approval by @dveeden

@shlomi-noach shlomi-noach self-assigned this Aug 19, 2016
@shlomi-noach

Copy link
Copy Markdown
Contributor Author

Testing passes. Am also working on local tests to verify this particular error, in separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant