Skip to content

DML write wrapped in transaction - #172

Merged
shlomi-noach merged 2 commits into
masterfrom
transactional-apply-dml
Aug 19, 2016
Merged

shlomi-noach merged 2 commits into
masterfrom
transactional-apply-dml

Conversation

@shlomi-noach

@shlomi-noach shlomi-noach commented Aug 18, 2016 •

Copy link
Copy Markdown
Contributor

Required for:

also solving the golang limitation:

sql: converting Exec argument #2's type: uint64 values with high bit set are not supported

by converting uint64 silently to strings when applying DML changes.
Related: #157

  • contributed code is using same conventions as original code
  • code is formatted via gofmt (please avoid goimports)
  • code is built via ./build.sh
  • code is tested via ./test.sh

Shlomi Noach added 2 commits August 18, 2016 13:31
- solving the golang problem: 'sql: converting Exec argument #2's type: uint64 values with high bit set are not supported'
@shlomi-noach

Copy link
Copy Markdown
Contributor Author

I'm running this through testing for the duration of the day. When this passed, I'm happy to merge in the TZ fix.

cc @dveeden

@shlomi-noach

Copy link
Copy Markdown
Contributor Author

This passes tests well

@shlomi-noach
shlomi-noach merged commit 41d4393 into master Aug 19, 2016
@shlomi-noach
shlomi-noach deleted the transactional-apply-dml branch August 19, 2016 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant