Repository navigation
Fix unsigned columns - #160
Merged
Merged
Conversation
added 6 commits
August 15, 2016 15:23
…r, query and args
Contributor
Author
|
This passes production tests |
Contributor
|
I also hit this issue and can confirm that the fix seem to work. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storyline: #157
This PR checks and fixes unsigned datatypes.
It seems the binary log does not tell us whether int values are signed or unsigned. The
go-mysqllibrary assumes signed.gh-ostuses its own understanding of migrated table structure to modify column type (on app side) on the fly frominttouinton all variations (8, 16, 32, 64).This fixes a data-corruption problem which can go undetected without
STRICT_ALL_TABLES.gofmt(please avoidgoimports)./build.sh./test.sh