Repository navigation
Cannot start line with ‘On’ in reply #23
Description
A bottom-quoted email that has a line in the reply start with “On” will discard that line and everything below it.
The code responsible can be found on line #87-90 of email_reply_parser.rb:
if text =~ /^(On\s(.+)wrote:)$/nm
# Remove all new lines from the reply header.
text.gsub! $1, $1.gsub("\n", " ")
end
An example email that shows the issue follows:
On your remote host you can run:
telnet 127.0.0.1 52698
This should connect to TextMate (on your Mac, via the tunnel). If that
fails, the tunnel is not working.
On 9 Jan 2014, at 2:47, George Plymale wrote:
> I am having an odd issue wherein suddenly port forwarding stopped
> working in a particular scenario for me. By default I have ssh set to
> use the following config (my ~/.ssh/config file):
> […]
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/textmate/rmate/issues/29
Activity
danielchatfield commentedon Aug 13, 2014
As far as I can see the code you have quoted won't do that - using http://rubular.com I can't get it to match that entire paragraph.
sorbits commentedon Aug 13, 2014
You probably forgot to add the options.
Here is the regexp and example text from my issue:
http://rubular.com/r/6VimI2jkFX
On 13 Aug 2014, at 16:37, Daniel Chatfield wrote:
danielchatfield commentedon Aug 13, 2014
👍
danielchatfield commentedon Aug 13, 2014
Could this be fixed by first trying to match a single line and then only if that doesn't match look for a multiline header. Seems like it should work.
Make reply header regexp even less greedy
danielchatfield commentedon Aug 13, 2014
Pull request opened
add test case from #23
technoweenie commentedon Aug 25, 2014
Should be fixed in v0.5.8. If not, please give us another test case.
sorbits commentedon Aug 26, 2014
Thanks!
Maybe worth adding the test case from the first PR:
danielchatfield@c7678f0#commitcomment-7374421
On 26 Aug 2014, at 1:53, risk danger olson wrote:
sorbits commentedon Dec 11, 2014
Is GitHub using this version? Cause I am still occasionally seeing issues, most latest one is here textmate/markdown.tmbundle#25 (comment)
But as far as I can tell, this version should not have a problem with the linked email reply.
danielchatfield commentedon Dec 11, 2014
@sorbits Doesn't look like they have updated.
gsdean commentedon Feb 11, 2015
FWIW zapier ported this, and just fixed the same issue
zapier/email-reply-parser#12
Merge branch 'master' of https://github.com/github/email_reply_parser …
Merge branch 'github-master'
mattyoho commentedon Jan 29, 2019
This issue has been fixed, I believe, thanks.