Repository navigation
Add JBoss logging - #3487
Merged
aschackmull merged 2 commits intoMay 19, 2020
Merged
Add JBoss logging#3487
Conversation
1 task done
aschackmull
requested changes
May 18, 2020
aschackmull
left a comment
aschackmull
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but the autoformat check failed.
Contributor
Author
|
@aschackmull Thanks for reviewing this PR. The changes are minimal and I used the command "Format Document" in the CodeQL extension for Visual Studio Code before I submitted the updated query so I don't understand why auto-format failed. Shall I use a different approach to auto-format before submitting a query? Is there something I can do to fix the problem? |
Contributor
|
I think you're doing it right, but accidentally added a newline at the end of the file after autoformatting. Just hit autoformat one more time and then the spurious newline should go away, thus making the PR check happy :-) |
Contributor
Author
|
Thanks @aschackmull , I've removed the ending blank line. |
aschackmull
approved these changes
May 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the recommendation from @aibaars in GitHub SecurityLab Issue #51, JBoss logging is added to this query so that issues like CVE-2019-10212 can be detected by this query.
Please consider to merge this PR.
Thanks,
@luchua-bc