Skip to content

Documentation update for Issue #2623 - #2641

Merged
jbj merged 4 commits into
github:masterfrom
marcrepo:master
Jan 29, 2020
Merged

jbj merged 4 commits into
github:masterfrom
marcrepo:master

Conversation

@marcrepo

Copy link
Copy Markdown
Contributor

Fixes the documentation issues raised in Issue #2623

This pull request is in reference to Issue github#2623 - "DescriptorNeverClosed.ql identifies only sockets (not file handles)"
Changes based on Issue github#2623 - DescriptorNeverClosed.ql identifies only sockets (not file handles)
Removed word "file" from description (see Issue 2623)
Documentation update for Issue github#2623
@marcrepo
marcrepo requested review from a team and hubwriter as code owners January 17, 2020 09:58
@ghost

ghost commented Jan 17, 2020 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jbj jbj added the C++ label Jan 17, 2020
@jbj jbj self-assigned this Jan 17, 2020

@jbj jbj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix! I've started the CI tests.

@marcrepo The next step is for you to sign the contributor license agreement. See the message above from @semmle-cla.

@jbj
jbj merged commit d7e8ea7 into github:master Jan 29, 2020

@hubwriter hubwriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants