[paladique]

Fixes #599

Paired on this with @donokuda to find out that although VSButtonStyle was using the default VS button style, it didn't have any additional info that a custom style could be set. So instead we updated GitHubVsButton, replaced VSButtonStyle with it, and made small changes to the button states to make it uniform with TE buttons.

Don also noticed that the margins within the button were a little off in comparison to the other TE buttons, should we adjust that?

Another thing of note is that VSButtonStyle is still being used on the Publish Repository button, should that be switched out as well?

Black

Blue

White

[grokys]

Does this only apply to VS15, not 2015?

[paladique]

@grokys Testing this out was all done in VS2015, but I'll check the effects it has in VS15

[shana]

I checked, VS15 is the same.

WRT margins, I like our button, it looks balanced. The TE buttons look heavy at the bottom. I'm fine with it as-is personally, it's going to be nicely balanced on the Publish UI too (let's get screenshots of that one to make sure)

[paladique]

Here's the publish button with GitHubVsButton style

Blue

Light

Dark

[shana]

Another thing of note is that VSButtonStyle is still being used on the Publish Repository button, should that be switched out as well?

Yup, let's switch that one as well and get everything uniform.

[shana]

Weird, I forgot to hit enter on the previous comment until now... looks good to me! We do look a bit fatter on that button but dunno, @donokuda?

[donokuda]

Weird, I forgot to hit enter on the previous comment until now... looks good to me! We do look a bit fatter on that button but dunno, @donokuda?

We do, I think it's better to adjust the padding so that we're consistent with the default button styles.

If I recall correctly, if we adjust the padding on the button, then we also need to do the same with the primary button styles so that they'll look consistent on the create pull request view.

We could follow up the padding in a separate PR if that makes sense. Don't want that blocking this PR since it feels like fairly minor cosmetic nit-pick.

[shana]

Sounds good, let's do that!