[jau228]

This is basically pulling strings from xaml and place them in the resource file. And using static binding to link those strings. I also added an exception in the GitHubVS.ruleset to ignore CA1701 for the string renaming error("UserName" instead of "username", "Github" instead of "GitHub", etc...) I am not seeing a whole lot of strings beside the GitHub.VisualStudio project. So this is what I focus so far.

[shana]

Thanks for taking this on!

There are some strings on .cs files that need to be moved to resources too, particularly in the "TeamExplorer" folder.

[haacked]

Minor nit, but could you fix the indenting? We use spaces, not tabs.

[haacked]

@jau228 THANK YOU for taking this on! It may take a little time for us to fully review. We've left you a few minor notes already.

[jau228]

I will move those strings from TeamExplorer folder this week.

[jau228]

The naming convention i used so far is {ControlName}{AttributeName}. eg. loginButtonContent, nameTextBlockText, helpCheckBoxToolTip, etc...

[haacked]

The naming convention i used so far is {ControlName}{AttributeName}. eg. loginButtonContent, nameTextBlockText, helpCheckBoxToolTip, etc...

That seems good to me. @shana?

[shana]

The naming convention i used so far is {ControlName}{AttributeName}. eg. loginButtonContent, nameTextBlockText, helpCheckBoxToolTip, etc...

That seems good to me. @shana?

Yup, sounds good, that way it'll be easy to search&replace if we need to 👍

[shana]

Hey hey! Just dropping a note to let you know this is not forgotten! I need to ship a release before I tackle open PRs (of which there are a few), I'll get to this soon!

[jau228]

yep, no problem. I am new to GitHub, so I am just trying to find projects to contribute.