This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
Fix null commit author - #2255
Merged
StanleyGoldman merged 6 commits intoMar 11, 2019
Merged
Conversation
michaelbayles
force-pushed
the
fix-null-commit-author
branch
from
March 3, 2019 07:18
15afbdf to
220ac7a
Compare
Contributor
|
👋 @michaelbayles, thank you for your contribution! 🎉 @jcansdale @StanleyGoldman can you help review this PR please? |
Contributor
|
Hey @michaelbayles thanks for catching this. |
Contributor
|
Related #2276 |
StanleyGoldman
removed their request for review
March 8, 2019 16:52
jcansdale
approved these changes
Mar 11, 2019
jcansdale
left a comment
jcansdale
left a comment
Collaborator
There was a problem hiding this comment.
Confirmed the bug and the fix.
This is good to go. 👍
Contributor
|
Thanks for starting this off @michaelbayles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
authoris null for a particular commit, the entire Pull Request cannot load. This simple fix looks into the commit authorship instead