This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
Fix crash when text entered into pull request search box - #2174
Merged
Merged
Conversation
OnStartSearch is called on a background thread. Marshal onto UI thread when updating view model.
Now that OnStartSearch is updating IGitHubPaneViewModel on the UI thread, calling SearchAsync with a duplicate query no longer crashes. We no longer need to trim whitespace and compare.
grokys
approved these changes
Jan 14, 2019
grokys
left a comment
grokys
left a comment
Contributor
There was a problem hiding this comment.
LGTM and fixes the crash! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The
OnStartSearchmethod is called on a background thread which was causing the newThreadHelper.ThrowIfNotOnUIThread()call to throw (and crash Visual Studio). The check was correct and appears to also show the reason #1950 was necessary.OnStartSearchonto the UI thread before updatingIGitHubPaneViewModelUpdateSearchHostwhich was necessary because of this issueHow to test
Fixes #2149