This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
Make VSGitExt use GitSccProvider UIContext - #1926
Merged
Merged
Conversation
It appears that using UICONTEXT.RepositoryOpen in VSGitExt doesn't work consistently. Revert back to using the GitSccProvider UIContext.
jcansdale
changed the title
grokys
approved these changes
Sep 20, 2018
grokys
left a comment
grokys
left a comment
Contributor
There was a problem hiding this comment.
I'd actually noticed this but assumed it was just a delay, because it did seem to load at some point. However, there's definitely no delay with this, initializes much faster 👍
Contributor
|
Thanks for doing this @jcansdale! I'm late, but LGTM. ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
It appears that using UICONTEXT.RepositoryOpen in VSGitExt doesn't work consistently.
Fixes #1924