This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
Revert pull request #1714 - #1872
Merged
Merged
Conversation
grokys
requested review from
StanleyGoldman,
drguthals,
jcansdale,
meaghanlewis and
shana
August 22, 2018 16:05
shana
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After testing #1714 was shown to cause problems with the extension. Although we think these problems should be fixed by #1871, we've decided that we need more time for testing.
We're reverting #1714 for now, but this PR will make it into our next release after we can be certain that it's not caused other issues.
Pinging @maikebing for visibility - thanks! Your work is really appreciated and we'll make sure to get it into the next release, we just need a little more time :)