Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Auto detect tests in Appveyor - #1425

Merged
meaghanlewis merged 10 commits into
masterfrom
task/auto-detect-tests
Feb 6, 2018
Merged

meaghanlewis merged 10 commits into
masterfrom
task/auto-detect-tests

Conversation

@meaghanlewis

@meaghanlewis meaghanlewis commented Jan 22, 2018 •

Copy link
Copy Markdown
Contributor

This PR removes:

  • The test_script block from appveyor.yml and uses Appveyor's auto testing mode instead
  • The Appveyor flag from scripts\test.ps1
  • The package NUnit.Extension.AppVeyor.NUnit3ResultWriterand all references to it

Closes #1289

@grokys

grokys commented Jan 23, 2018 •

Copy link
Copy Markdown
Contributor

The latest build on master ran 806 total tests, but this PR is running 804 total tests (Seems to be running 4 less tests in UnitTests and 2 more tests in TrackingCollectionTests)

In the case of UnitTests, this seems to be caused the ignored GraphsNavigationItemTests.TheExecuteMethod test. This test was appearing in the list of tests before, but the status was gray indicating that it was ignored, whereas now the test isn't included in the list. The test has 4 TestCases so this explains that.

In the case of TrackingCollectionTests; MultipleSortingAndFiltering and OrderByDoesntMatchOriginalOrderTimings are now being run where they weren't before. These two tests are marked with Category("Timings"), which was marked as being ignored before. You can use appveyor.yml to ignore these files.

grokys
grokys previously approved these changes Jan 25, 2018
@shana

shana commented Jan 29, 2018

Copy link
Copy Markdown
Contributor

Should I update scripts\test.ps1 and remove the Appveyor flag since it seems we'll only be using this script locally now?

Yup, and you can also remove the NUnit.Extension.AppVeyor.NUnit3ResultWriter package from our nuget solution (in VS, Tools -> Nuget Package Manager -> Manage Nuget Packages for Solution and then in the Installed tab find the package and uninstall it from all projects that have it installed). After that, you can delete the NUnit.Extension.AppVeyor.NUnit3ResultWriter.0.1.0.nupkg package from lib/ 😄

@meaghanlewis
meaghanlewis merged commit 21f82b4 into master Feb 6, 2018
@meaghanlewis
meaghanlewis deleted the task/auto-detect-tests branch February 6, 2018 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants