Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Externally contributed pull requests get stuck in loop fetching/refreshing #2343

Closed
#2344
Closed
Externally contributed pull requests get stuck in loop fetching/refreshing#2343
#2344
Assignees
jcansdale
Labels
bug

Description

@jcansdale
jcansdale
opened on May 2, 2019

Versions

  • GitHub Extension for Visual Studio version: v2.9.0.7614
  • Visual Studio version: All

What happened

I opened and checked out a pull request that has been created by an external user (not originating from the local repository). The pull request detail pane got stuck in a loop where it would keep refreshing and fetching.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Clone https://github.com/mayerwin/vs-customize-window-title
  2. Open pull request 47 from list
  3. Checkout pull request
  4. Pull request gets stuck in a fetch/refresh loop
  5. Click refresh if loop hasn't started

Expected behavior

Pull request should load once and not continually fetch/refresh!

Screenshots

image

Logs

2019-05-01 10:25:29.710 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:30.978 [22120] DBUG [17] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:30.997 [22120] DBUG [17] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:31.042 [22120] DBUG [18] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:32.301 [22120] DBUG [26] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:32.313 [22120] DBUG [26] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:32.404 [22120] DBUG [23] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:37.275 [22120] DBUG [06] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:37.280 [22120] DBUG [06] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:37.343 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:41.895 [22120] DBUG [18] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:41.901 [22120] DBUG [18] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:42.099 [22120] DBUG [22] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:43.982 [22120] DBUG [22] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:43.996 [22120] DBUG [22] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:45.002 [22120] DBUG [11] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed
2019-05-01 10:25:47.335 [22120] DBUG [18] VSGitExt                  IGitExt.ActiveRepositories (#12828799) returned ["C:\\Source\\github.com\\mayerwin\\vs-customize-window-title"]
2019-05-01 10:25:47.342 [22120] DBUG [18] VSGitExt                  ActiveRepositories changed to ["https://github.com/mayerwin/vs-customize-window-title"]
2019-05-01 10:25:47.544 [22120] DBUG [22] TeamExplorerContext       Fire StatusChanged event if anything about an active repository has changed

image

Additional context

This doesn't happen on the previous v2.8.1.7307 version.

Activity

  1. jcansdale
    changed the title [-]Externally contributed pull request get stuck in loop fetching/refreshing[/-] [+]Externally contributed pull requests get stuck in loop fetching/refreshing[/+] on May 2, 2019
  2. jcansdale
    self-assigned this
    on May 2, 2019
  3. jcansdale
    added
    bug
    on May 2, 2019
  4. StanleyGoldman
    closed this as completedin #2344on May 2, 2019

  5. Lexiphan commented on May 6, 2019

    @Lexiphan
    Lexiphan
    on May 6, 2019

    This was not solved! Still refreshing in a loop.

  6. github
    deleted a comment from on May 6, 2019

  7. meaghanlewis commented on May 6, 2019

    @meaghanlewis
    meaghanlewis
    on May 6, 2019
    Contributor

    @Lexiphan thanks for letting us know. Just to double check, you are using the latest version of the extension, v2.9.1.7781 right? If so, feel free to reopen this issue.

  8. jcansdale commented on May 7, 2019

    @jcansdale
    jcansdale
    on May 7, 2019
    CollaboratorAuthor

    @Lexiphan,

    I'm keen to get to the bottom of this if it still isn't working in the latest release. Could you click Extensions > Manage Extensions and check that you're running v2.9.1.7781?

    image

    I'm really hoping you're running an earlier version! 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bug

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions