This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Links to outdated comments in pull request reviews don't work #2247
Description
Versions
- GitHub Extension for Visual Studio version: 2.8.0
- Visual Studio version: All
What happened
I opened a pull request review and clicked on link to an outdated comment. Nothing happened.
Steps to Reproduce
Steps to reproduce the behavior:
- Open
github/VisualStudiopull request 2241 on GitHub pane - Click on
Reviewers > jcansdale - Expand
Outdated comments - Click on one of the outdated comment links
- Nothing happens
Expected behavior
File diff appears with selected comment.
If this can't be made to work, maybe we could open the comment on dotcom?
Screenshots
Research
The issue appears to be that that the PullRequestSessionFile doesn't have any associated InlineCommentThreads.
Activity
grokys commentedon Feb 28, 2019
If you debug into
PullRequestReviewCommentViewModel.DoOpenand click on one of the comments, you can see that it's trying to get the file at the branch's HEAD commit, but at this commit the comment is outdated. So looks like we need to check the thread model and if it's outdated use theOriginalCommitSha.Also
PullRequestSessionService.BuildCommentThreadsappears to filter out outdated threads, so that check probably needs to be removed (at least if building comments for the non-HEAD commit?)