This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
GitHub Enterprise over http unable to adding review comment #2224
Description
Versions
- GitHub Extension for Visual Studio version: 2.7.1.6591
- Visual Studio version: 2017 Pro
What happened
I have github for enterprise intranet server deployed. There server only supports http connection (HTTP://github.{mycompany}.com). When works fine, until I try to add a comment for PR, it shows "An error occurred while sending the request". In Fiddler I can see, that it tries to send requests to HTTPS:443 tunnel, even though all other requests work fine and go through HTTP:80, including showing list of available PRs and shows existing comments fine.
Steps to Reproduce
Steps to reproduce the behavior:
- Add local Github for Enterprise deployed to local HTTP (not HTTPs) server
- Open some active PR for review in Visual Studio
- Try to add new review comment for the PR
- See error "An error occurred while sending the request"
Expected behavior
Successfully add request
Screenshots
Activity
jcansdale commentedon Mar 25, 2019
Hi @pmunin,
Sorry about the delay getting back to you!
I've been doing some investigation as it isn't obvious why it would be doing this. We should be preserving the HTTP or HTTPS protocol of the host.
Could you try using the
File > Open > Open from GitHub...command and let me know if the repository list appears for your Enterprise server? This uses GraphQL just like the API for posting a comment.pmunin commentedon Mar 25, 2019
Just tried your advice, opened/cloned github repo from file/Open menu - same story, opens PR, and shows changes, but fails to add any comments to it. Just try this action on a local github server where HTTPS is unavailable (only HTTP)
jcansdale commentedon Mar 26, 2019
Thanks for letting me know. This is strange because the open/clone dialog uses GitHub v4/GraphQL API. I thought initially that the GitHub v4/GraphQL API might always be using HTTPS.
I'm wondering if the issue might be the version of GitHub Enterprise you're using rather than HTTPS? Do you know which version you have installed?
pmunin commentedon Mar 26, 2019
It says
Enterprise Server 2.13, when I open github/helpStanleyGoldman commentedon Mar 28, 2019
I am able to reproduce this issue using Enterprise 2.1.3 over http.
jcansdale commentedon Mar 29, 2019
Hi @pmunin,
We're hoping this issue is fixed in #2305.
Could you try installing the VSIX from the following location and let me know if that resolves the issue
https://ci.appveyor.com/project/github-windows/visualstudio/builds/23437511/artifacts
If you could comment on #2305, that would be great. 😄
pmunin commentedon Mar 29, 2019
Just tested, works now! 👍 replied to #2305 as well. Thanks!
[-]PR adding review comment request fails for HTTP enterprise server[/-][+]GitHub Enterprise over http unable to adding review comment[/+]