GitHub extension stopped reporting progress when cloning from the Start Page

In all recent versions of the GitHub extension, I've noticed that a clone from the Start Page does not show progress on the status bar of Visual Studio.

On debugging the Clone API call in Team Explorer I found that a null IProgress was being sent and hence progress cannot be reported.

We're planning to add this feature to the Start Window and this lack of progress will cause experience gaps.

@jcansdale

@jcansdale / @meaghanlewis looping you in based on the history of this repo 😄 I think @shana worked on the original implementation.

I'm on the VS team and noticed this on the debugger. I think progress is currently broken in the clone api that the GitHub extension calls, so if you could validate that when IProgress passed to the clone API is non-null, that would help a lot.

This is the file where a Code Container Provider is declared: VisualStudio/src/GitHub.StartPage/StartPagePackage.cs

I'm happy to talk more if needed.

//cc: @prnadago

@prasethu

Hi @prasethu,

I disabled this when working on a VS 2019 compatible version before the VS preview was out.

VisualStudio/src/GitHub.TeamFoundation.14/Services/VSGitServices.cs

Lines 82 to 98 in e98aa41

    
           #if TEAMEXPLORER14 
        
                       await StartClonenOnConnectPageAsync(teamExplorer, cloneUrl, clonePath, recurseSubmodules); 
        
                       NavigateToHomePage(teamExplorer); // Show progress on Team Explorer - Home 
        
                       await WaitForCloneOnHomePageAsync(teamExplorer); 
        
           #elif TEAMEXPLORER15 || TEAMEXPLORER16 
        
                       // The ServiceProgressData type is in a Visual Studio 2019 assembly that we don't currently have access to. 
        
                       // Using reflection to call the CloneAsync in order to avoid conflicts with the Visual Studio 2017 version. 
        
                       // Progress won't be displayed on the status bar, but it appears prominently on the Team Explorer Home view. 
        
                       var gitExt = serviceProvider.GetService<IGitActionsExt>(); 
        
                       var cloneAsyncMethod = typeof(IGitActionsExt).GetMethod(nameof(IGitActionsExt.CloneAsync)); 
        
                       Assumes.NotNull(cloneAsyncMethod); 
        
                       var cloneParameters = new object[] { cloneUrl, clonePath, recurseSubmodules, null, null }; 
        
                       var cloneTask = (Task)cloneAsyncMethod.Invoke(gitExt, cloneParameters); 
        
                       NavigateToHomePage(teamExplorer); // Show progress on Team Explorer - Home 
        
                       await cloneTask; 
        
           #endif

Now that I've got the VS 2019 assemblies to target, I should be able to reinstate it. 🤞 I'll keep you posted!

@jcansdale

Thanks @jcansdale ! There's a chance that this experience will ship in the next preview, so if you could make this work and build me a private VSIX I can try it on my side.

Navigation Menu

Repository navigation

GitHub extension stopped reporting progress when cloning from the Start Page #2196

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	#if TEAMEXPLORER14
	await StartClonenOnConnectPageAsync(teamExplorer, cloneUrl, clonePath, recurseSubmodules);
	NavigateToHomePage(teamExplorer); // Show progress on Team Explorer - Home
	await WaitForCloneOnHomePageAsync(teamExplorer);
	#elif TEAMEXPLORER15 \|\| TEAMEXPLORER16
	// The ServiceProgressData type is in a Visual Studio 2019 assembly that we don't currently have access to.
	// Using reflection to call the CloneAsync in order to avoid conflicts with the Visual Studio 2017 version.
	// Progress won't be displayed on the status bar, but it appears prominently on the Team Explorer Home view.
	var gitExt = serviceProvider.GetService<IGitActionsExt>();
	var cloneAsyncMethod = typeof(IGitActionsExt).GetMethod(nameof(IGitActionsExt.CloneAsync));
	Assumes.NotNull(cloneAsyncMethod);
	var cloneParameters = new object[] { cloneUrl, clonePath, recurseSubmodules, null, null };
	var cloneTask = (Task)cloneAsyncMethod.Invoke(gitExt, cloneParameters);

	NavigateToHomePage(teamExplorer); // Show progress on Team Explorer - Home
	await cloneTask;
	#endif

GitHub extension stopped reporting progress when cloning from the Start Page #2196

Description

Activity

prasethu commented on Jan 23, 2019

jcansdale commented on Jan 24, 2019

prasethu commented on Jan 24, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions