This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Don't leave behind empty directory when a clone fails #2126
Description
Versions
- GitHub Extension for Visual Studio version: 2.6.0
- Visual Studio version: 2015 (probably all)
What happened
- Attempted to clone
grokys/PullRequestSandbox3(which doesn't exist) - Attempted to clone
grokys/PullRequestSandboxto thegrokys\PullRequestSandbox3folder - Was block because there's an empty directory in the target destination
Expected behavior
- User should be able to clone into empty directory
- When a clone fails, the empty directory created for the clone should be deleted.
Screenshots
Note: The logic that the new Visual Studio 2019 Get to Code feature uses is that a directory must be empty or not exist on order to clone. I think we should be consistent with this and allow cloning to empty directories.
Activity
jcansdale commentedon Feb 26, 2019
Yes, I definitely agree.
jcansdale commentedon Feb 28, 2019
@YuPeiHenry,
Could you open a new issue with this so we don't forget it when your pull request is merged? 🙂
YuPeiHenry commentedon Mar 1, 2019
@jcansdale I have opened a new issue #2250 to address cloning into empty directories.