Extension ships with a newer Newtonsoft.Json than Visual Studio 2017 #1774

Activity

1. grokys commented on Jul 10, 2018

   

   grokys

   on Jul 10, 2018

   Contributor

   More actions

   The reason we're now doing this is that one of our dependencies uses 10.0. I can check whether that dependency is happy with 9.0, but if not, what is the recommended way of fixing this?
2. grokys

   added a commit that references this issue on Jul 11, 2018

   Downgrade Newtonsoft.Json to 9.0.1.

   ...

   980b390
3. jcansdale commented on Jul 11, 2018

   

   jcansdale

   on Jul 11, 2018

   Collaborator

   More actions

   @kzu 👋 should we treat Newtonsoft.Json as a Visual Studio assembly and not package it at all?
4. kzu commented on Jul 11, 2018

   

   kzu

   on Jul 11, 2018

   Author

   More actions

   That's tricky. We had package load failures in some cases if we didn't distribute it, so we always make sure we distribute the same version as the VS we ship with :(
5. kzu commented on Jul 11, 2018

   

   kzu

   on Jul 11, 2018

   Author

   More actions

   Also of interest: VS ships with binding redirects for this, currently:

   			<dependentAssembly>
   				<assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral"/>
   				<bindingRedirect oldVersion="1.0.0.0-9.0.0.0" newVersion="9.0.0.0"/>
   			</dependentAssembly>
   

   So you can build against any older version, but not newer.
6. jcansdale commented on Jul 12, 2018

   

   jcansdale

   on Jul 12, 2018

   Collaborator

   More actions

   @kzu,

   It appears VS 2015 only knows about 4.5.0.0-6.0.0.0:

                   <dependentAssembly>
                       <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral"/>
                       <bindingRedirect oldVersion="4.5.0.0-6.0.0.0" newVersion="6.0.0.0"/>
                   </dependentAssembly>

   Do you know what is happening to cause the breakage? I can't immediately think of a scenario short of an extension calling Assembly.Load("Newtonsoft.Json") and assuming a particular version. I'd like to understand what's going on here.

   I'm wondering if we should be using a [ProvideCodeBase] attribute for Newtonsoft.Json? We're now using ProvideBindingPath to make sure that our assemblies can be resolved (including from .imagemanifest, see #1236).

   This will have the side effect of making our version of Newtonsoft.Json available via Assembly.Load("Newtonsoft.Json"). We could put it on a different path and explicitly specify its code base.
7. StanleyGoldman

   closed this as completedin #1767on Jul 12, 2018
8. meaghanlewis

   added this to the 2.5.4 milestone on Jul 12, 2018
9. grokys

   added a commit that references this issue on Oct 5, 2018

   Reference Newtonsoft.Json 9.0.1

   ...

   c959459