Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Add GitHub option back to start page in VS2017 #1310

Closed

Description

@meaghanlewis

Tested on:
Visual Studio version: VS2017, 15.4.3

This option was apparent in the last GHfVS release v2.3.4.54 but stopped working after that.
I notice the icon disappear after #1282 was merged to master, but am not sure about the exact commit

What happened
Open VS2017 with the latest dev build on master and look on the start page.

Expected: GitHub option is present
screen shot 2017-11-09 at 10 25 45 am

Actual: GitHub option is not present
screen shot 2017-11-09 at 10 23 13 am

Activity

  1. grokys commented on Nov 10, 2017

    @grokys
    Contributor

    Ok, strange - just tried this on master in the experimental instance and it's working, but can confirm it's not working with the package from CI.

  2. grokys commented on Nov 10, 2017

    @grokys
    Contributor

    One thing I notice is that in the experimental instance the Start Page package is listed under Extensions and Updates:

    image

    However in the main instance it isn't:

    image

    My guess is that something in #1282 broke installing the secondary package.

  3. shana commented on Nov 13, 2017

    @shana
    Contributor

    Likely this was broken by the fact that the GitHub.StartPage.pkdgef file was no longer included in the vsix. @meaghanlewis Could you test https://ci.appveyor.com/project/github-windows/visualstudio/build/2.3.5.307 and see whether this guess is correct and the start page is indeed fixed?

  4. meaghanlewis commented on Nov 13, 2017

    @meaghanlewis
    ContributorAuthor

    Yes, this issue is indeed fixed in build 2.3.5.307. Thanks @shana 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions