Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Checked out PR file diffs sometimes complain about different encodings #1010

Closed

Description

@jcansdale
  • GitHub Extension for Visual Studio version: 2.2.1.100 (dev)
    Visual Studio version: 2015
  1. Select a PR
  2. Checkout PR
  3. Double-click on PR file and open diff view

Sometimes the diff view complains that the files have different encodings (UTF-8 vs Windows).

image

Activity

  1. self-assigned this
    on Jun 13, 2017
  2. added a commit that references this issue on Jun 13, 2017
    bb47311
  3. jcansdale commented on Jun 13, 2017

    @jcansdale
    CollaboratorAuthor

    It appears Visual Studio likes to add UTF-8 headers to files it touches. 😕 This seems to change them from being the default Western European (Windows-1252) to being UTF-8.

    When creating a temp file to diff against, we should save it as UTF-8, if the working file has been changed to UTF-8.

  4. added 2 commits that reference this issue on Jun 13, 2017
    fbf5a4f
    e9e3cd9
  5. jcansdale commented on Jun 13, 2017

    @jcansdale
    CollaboratorAuthor

    Fixed in #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions